[webkit-dev] More thoughts on cleaning up the root directory

Hajime Morita morrita at google.com
Mon Dec 27 02:47:27 PST 2010


Hi, thank you for leading the reorg.

> Sources/
>  automake/
>  cmake/
>  JavaScriptCore/
>  JavaScriptGlue/
>  Platform/ (was WebCore/platform)
I'd like to keep platform directory under WebCore if there is no strong reason.

Classes under WebCore/platform have WebCore namespace,
and the boundary between platform/ and rest of WebCore isn't clear for me.
(For example, there is rendering/RenderThemeMac.mm and
platform/qt/RenderThemeQt.cpp)
We also often change platform and non-platform classes at the same
time, that implies these tight coupling.
So having these classes under same top directory will make the
changelog more readable.

Regards.
--
morrita

>  WebCore/
>  WebKit/
>  WebKit2/
>  WTF/ (was JavaScriptCore/wtf)
>  ThirdParty/
>    ANGLE/
>    + Contents WebKitLibraries
> Tools/
> Websites/
> .gitattributes
> .gitignore
> ChangeLog
> Makefile
> Makefile.shared
>
> == UNSURE ==
> autogen.sh
> Android.mk
> common.pri
> cmakeconfig.h.cmake
> CMakeLists.txt
> configure.ac
> GNUmakefile.am
> wscript
> DerivedSources.pro
> WebKit.pri
> WebKit.pro
>
> In this layout, I haven't merged PerformanceTests and RegressionTests
> for two reasons.  First, the natural name, Tests, conflicts with
> tab-completing Tools.  Second, folks so commonly access the current
> LayoutTests directory that it seems a bit inefficient to place it
> another level lower in the directory hierarchy.
>
> Comments welcome, of course.  :)
>
> Adam
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>



-- 
morrita


More information about the webkit-dev mailing list