[webkit-dev] A bot-filled future?
Adam Roben
aroben at apple.com
Thu Nov 12 20:20:29 PST 2009
On Nov 12, 2009, at 6:59 PM, Ojan Vafai wrote:
> On Thu, Nov 12, 2009 at 3:48 PM, Adam Roben <aroben at apple.com> wrote:
> On Nov 12, 2009, at 6:38 PM, Ojan Vafai wrote:
>> 2. Can grab layout test results from the try servers. This would reduce the need/occurence of committing Mac expectations and then cleaning up other platforms post commit.
>
> Without being able to see the loaded page on that platform, how do you know if the results are correct?
>
> (If you're able to verify the results just based on the test output, maybe the test should be cross-platform!)
>
> This entirely depends on the change you're making. For example, with a change that makes buttons 1px wider it's easy to verify from the layout test diff that the new results are correct.
That's true.
> It's also easy to spot tests with "FAIL" or "PASS" in the output. :)
I'd hope that those tests would have cross-platform results, since clearly the condition is testable without having access to a full render tree dump.
-Adam
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20091112/4fb383a4/attachment.html>
More information about the webkit-dev
mailing list