[webkit-dev] namespace indent

David Hyatt hyatt at apple.com
Tue Dec 1 12:52:27 PST 2009


On Dec 1, 2009, at 2:42 PM, Adam Barth wrote:

> A common "false positive" in the style-queue is as follows:
> Code inside a namespace should not be indented.  [whitespace/indent]  
> [4]
> That's because the namespace indent rule is fairly new and its hard to
> fix without touching the whole file.  I don't think the style-queue
> should be spamming bugs with non-actionable information.  There seem
> to be a few choices:
> 1) Disable this warning because it's not helpful at the moment.
> 2) Change our code to comply with this style rule (e.g., as we touch
> files, fix them so that the warning doesn't occur).
> 3) Change our style guide to match our code.
> Personally, I'm in favor of (2) because it seems silly to have a rule
> in our style guide with which we never plan to actually comply.
> Thoughts?
> Adam
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

More information about the webkit-dev mailing list