[webkit-dev] namespace indent

Adam Barth abarth at webkit.org
Tue Dec 1 12:42:01 PST 2009

A common "false positive" in the style-queue is as follows:

Code inside a namespace should not be indented.  [whitespace/indent] [4]

That's because the namespace indent rule is fairly new and its hard to
fix without touching the whole file.  I don't think the style-queue
should be spamming bugs with non-actionable information.  There seem
to be a few choices:

1) Disable this warning because it's not helpful at the moment.
2) Change our code to comply with this style rule (e.g., as we touch
files, fix them so that the warning doesn't occur).
3) Change our style guide to match our code.

Personally, I'm in favor of (2) because it seems silly to have a rule
in our style guide with which we never plan to actually comply.



More information about the webkit-dev mailing list