[webkit-dev] Webkit render tree dump

David Hyatt hyatt at apple.com
Tue Dec 1 11:16:06 PST 2009

I actually have a giant set of changes that need to be made to the  
render tree dumping... many of which are outlined in comments.  The  
problem is it causes all the test results to have to be updated.

Right now many silly and incorrect things are being dumped right now  
just for backwards compatibility.  It's not ideal.


On Dec 1, 2009, at 1:14 PM, Darin Adler wrote:

> On Nov 30, 2009, at 6:29 PM, pundarik rajkhowa wrote:
>> Thanks for the info. I am aware of the pixel test, but for my  
>> purpose that cant be used, since text-based comparision is  
>> preferred. Regarding the style attributes, the webkit dump actually  
>> contains a few of them like color, bgcolor, borderstyle etc. Is  
>> there any specific reason for that ? Also if I dump other  
>> attributes like font-weight, text-decoration etc using the style()  
>> api of the RenderObject, will that help catching bugs specific to  
>> these attributes ?
> It would be OK to dump more. There are two difficulties:
>    1) If we add more to what is dumped, the additional information  
> may create even more noise in existing test results, repeated things  
> that make the salient details hard to find. The original choice of  
> what to dump was based on a tradeoff in a hope to make the dumps  
> readable.
>    2) If we add more to what is dumped, that patch has to update the  
> results of thousands of tests on multiple platforms.
> Sometimes you can come up with a rule to decide when to dump that  
> can mitigate both problems (1) and (2), for example, dumping only  
> when values are unusual.
>    -- Darin
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

More information about the webkit-dev mailing list