[webkit-dev] Is it OK to remove Frame::setIsDisconnected() and isDisconnected() ?

Adam Roben aroben at apple.com
Wed Apr 15 13:17:32 PDT 2009

On Apr 15, 2009, at 3:48 PM, Sverrir Á. Berg wrote:

> Working on a change in FrameTree and noticed that the checks in  
> top() and parent() for 'checkForDisconnectedFrame' rely on a flag in  
> Frame that as far as I can tell is never set.
> So my naive question is: Can I remove the corresponding code from  
> Frame and FrameTree?  If not I would like if somebody could explain  
> how they are used so I don't break anything with my change.
> More detail:
> * My search for calls to Frame::setIsDisconnected reveals no callers  
> in WebKit, Chromium or Google code search.

There are two callers:





More information about the webkit-dev mailing list