[webkit-dev] r35040 -- issue with gtk

Refstrup, Jacob Grundtvig jacob.refstrup at hp.com
Thu Jul 10 09:58:48 PDT 2008


With your recent change (r35040) to KURL.cpp in setRef() (line 708) testing for isNull() rather than isEmpty() caused a problem on GTK where called setRef("") which ends up being not being null (but would have been empty). This currently causes all file:// references to have added a '#' at the end of the URL -- which means file:// URLs won't load. The immediately obvious fix is to change WebCore/platform/network/curl/ResourceHandleManager.cpp:558 to use setRef(String()) rather than setRef(""). I grepped the code and there's a single other place (WebCore/page/AccessibilityRenderObject.cpp) that uses setRef("") -- not sure if that'll have to be changed to.

Kind regards,
- Jacob

More information about the webkit-dev mailing list