[webkit-dev] Re: Issues with font rendering on DirectFB build

[Mike Emmel]

Alp attached is my patch to remove X11 refs if you building for gtk/directfb.

Its not quite right since you have the case of X11/GTK on Windows
thats not dealt with.
I think some more changes are needed in the headers to build that variant.

It adds PLATFORM(X11) and PLATFORM(DIRECTFB)
I need the DIRECTFB one later for my movie backend using directfb
video providers.
Which I need to submit.
I don't think the GStreamer backend has to be gtk specific. We should
be able to
do a variety of bindings that are generic.

On Feb 13, 2008 7:29 AM, Mike Emmel <mike.emmel at gmail.com> wrote:
> So should defaultOptions be set to something sane  or is nulls ok ?
>
> I think the real problem is the above screen resolution issue but I'm
> not sure about
> the interaction between screen scaling and the base font options. It
> seems to me we don't want to allow fonts to scale below a certain size
> ?
>
> On a side note we should add get/setDefaultOptions and the above code
> should move into the webkit binding layer.
>
> Also the same for dpi I think it should be up in the app and we push
> the value down
> via get/setScreenResolution.
>
> This approach decouples the cairo/font code from gtk so it can be used
> for other ports.
>
>
>
>
>
>
> On Feb 13, 2008 3:27 AM, Alp Toker <alp at atoker.com> wrote:
> > Christian Dywan wrote:
> > >
> > > While that might fix the problem, hardcoding arbitrary values is not
> > > exactly advisable.
> > >
> > > It should be interesting to figure out what causes this function to fail
> > > in the first place.
> > >
> >
> > The answer lies in the documentation for gdk_screen_get_resolution():
> >
> >    Returns: the current resolution, or -1 if no resolution has been set.
> >
> > So Sriram's patch is absolutely correct (coding-style issues aside).
> >
> > _______________________________________________
> > webkit-dev mailing list
> > webkit-dev at lists.webkit.org
> > http://lists.webkit.org/mailman/listinfo/webkit-dev
> >
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dfb.patch
Type: text/x-patch
Size: 2804 bytes
Desc: not available
Url : http://lists.webkit.org/pipermail/webkit-dev/attachments/20080213/4861356c/dfb-0001.bin