[webkit-changes] [WebKit/WebKit] 8864e6: Adopt more smart pointers in WebExtensionContext a...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8864e650bf5ab2a2e90de8324002db7ba71c6f67
      https://github.com/WebKit/WebKit/commit/8864e650bf5ab2a2e90de8324002db7ba71c6f67
  Author: Rupin Mittal <rupin at apple.com>
  Date:   2024-09-26 (Thu, 26 Sep 2024)

  Changed paths:
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm
    M Source/WebKit/UIProcess/Extensions/WebExtensionAction.h
    M Source/WebKit/UIProcess/WebContextSupplement.h
    M Source/WebKit/UIProcess/WebGeolocationManagerProxy.cpp
    M Source/WebKit/WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp
    M Source/WebKit/WebProcess/Geolocation/GeolocationPermissionRequestManager.h
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.h

  Log Message:
  -----------
  Adopt more smart pointers in WebExtensionContext and WebGeolocationManagerProxy
https://bugs.webkit.org/show_bug.cgi?id=280420
rdar://136769688

Reviewed by Chris Dumez, Geoffrey Garen, and Timothy Hatcher.

Smart pointer adoption as per the static analyzer.

We are now able to use WebContextSupplement::protectedProcessPool() in
WebGeolocationManagerProxy::WebGeolocationManagerProxy since 284304 at main
makes it safe to ref an API object in it's constructor.

* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm:
(WebKit::WebExtensionAction::tab const): Deleted.
(WebKit::WebExtensionAction::window const): Deleted.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::getCurrentTab const):
(WebKit::WebExtensionContext::getAction):
(WebKit::WebExtensionContext::inspectorPageIdentifiers const):
(WebKit::WebExtensionContext::addExtensionTabPage):
* Source/WebKit/UIProcess/Extensions/WebExtensionAction.h:
(WebKit::WebExtensionAction::tab const):
(WebKit::WebExtensionAction::window const):
* Source/WebKit/UIProcess/WebContextSupplement.h:
(WebKit::WebContextSupplement::protectedProcessPool):
* Source/WebKit/UIProcess/WebGeolocationManagerProxy.cpp:
(WebKit::WebGeolocationManagerProxy::WebGeolocationManagerProxy):
(WebKit::WebGeolocationManagerProxy::startUpdatingWithProxy):
* Source/WebKit/WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
(WebKit::GeolocationPermissionRequestManager::ref const):
(WebKit::GeolocationPermissionRequestManager::deref const):
* Source/WebKit/WebProcess/Geolocation/GeolocationPermissionRequestManager.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::protectedGeolocationPermissionRequestManager):
* Source/WebKit/WebProcess/WebPage/WebPage.h:

Canonical link: https://commits.webkit.org/284338@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications