[webkit-changes] [WebKit/WebKit] 0377f9: Fix PlayStation build following 284305 at main

Ross Kirsling noreply at github.com
Thu Sep 26 22:24:41 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0377f91692999c5269879f68daf25ccdb393b77e
      https://github.com/WebKit/WebKit/commit/0377f91692999c5269879f68daf25ccdb393b77e
  Author: Ross Kirsling <ross.kirsling at sony.com>
  Date:   2024-09-26 (Thu, 26 Sep 2024)

  Changed paths:
    M Source/WebCore/css/color/CSSColorConversion+Normalize.h
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+Color.cpp
    M Source/WebCore/css/values/CSSPrimitiveNumericTypes+EvaluateCalc.h
    M Source/WebCore/css/values/CSSPrimitiveNumericTypes+SymbolReplacement.h
    M Source/WebCore/css/values/CSSUnevaluatedCalc.h
    M Source/WebCore/style/values/StyleValueTypes.h

  Log Message:
  -----------
  Fix PlayStation build following 284305 at main
https://bugs.webkit.org/show_bug.cgi?id=280491

Unreviewed build fix.

As I stated in 282722 at main, my fix for Sam's earlier patch 282670 at main:
std::optional::transform is a C++23 feature and, at least in the context of this patch,
is not pulling its own weight; it suffices to write an explicit early-out for nullopt.

The better solution here would probably be to add a WTF::mapOptional alongside switchOn.

* Source/WebCore/css/color/CSSColorConversion+Normalize.h:
(WebCore::normalizeAndClampNumericComponentsIntoCanonicalRepresentation):
(WebCore::normalizeNumericComponentsIntoCanonicalRepresentation):
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Color.cpp:
(WebCore::CSSPropertyParserHelpers::makeCSSUnresolvedColor):
* Source/WebCore/css/values/CSSPrimitiveNumericTypes+EvaluateCalc.h:
(WebCore::CSS::evaluateCalcIfNoConversionDataRequired):
* Source/WebCore/css/values/CSSPrimitiveNumericTypes+SymbolReplacement.h:
(WebCore::CSS::replaceSymbol):
* Source/WebCore/css/values/CSSUnevaluatedCalc.h:
(WebCore::CSS::simplifyUnevaluatedCalc):
* Source/WebCore/style/values/StyleValueTypes.h:
(WebCore::Style::toCSS):
(WebCore::CSS::toStyle):
(WebCore::CSS::toStyleNoConversionDataRequired):

Canonical link: https://commits.webkit.org/284337@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list