[webkit-changes] [WebKit/WebKit] 53c053: [Text Directionality] REGRESSION(282648 at main): Upd...

[Said Abou-Hallawa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 53c053e2da00fb71456baf69d1388b8c1158d38e
      https://github.com/WebKit/WebKit/commit/53c053e2da00fb71456baf69d1388b8c1158d38e
  Author: Said Abou-Hallawa <said at apple.com>
  Date:   2024-09-27 (Fri, 27 Sep 2024)

  Changed paths:
    M Source/WebCore/dom/Element.cpp
    M Source/WebCore/dom/ElementTextDirection.cpp
    M Source/WebCore/dom/ElementTextDirection.h

  Log Message:
  -----------
  [Text Directionality] REGRESSION(282648 at main): Updating the auto text directionality of the element's ancestors is very expensive
https://bugs.webkit.org/show_bug.cgi?id=280309
rdar://136385909

Reviewed by Ryosuke Niwa.

Skip updating the element's ancestors if the dir attribute was not changed and
its effective direction is the same as its parent's effective direction. This
element won't affect its ancestors' effective direction.

* Source/WebCore/dom/Element.cpp:
(WebCore::Element::dirAttributeChanged):
* Source/WebCore/dom/ElementTextDirection.cpp:
(WebCore::updateEffectiveTextDirectionOfElementAndDescendants):
(WebCore::textDirectionStateChanged):
(WebCore::updateEffectiveTextDirectionState):
* Source/WebCore/dom/ElementTextDirection.h:

Canonical link: https://commits.webkit.org/284339@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications