[webkit-changes] [WebKit/WebKit] f1063f: AX: ButtonFace color has bad contrast with ButtonT...

Tim Nguyen noreply at github.com
Fri Sep 6 16:33:32 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f1063f2472a1a0b6db2de2733772440248437a26
      https://github.com/WebKit/WebKit/commit/f1063f2472a1a0b6db2de2733772440248437a26
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2024-09-06 (Fri, 06 Sep 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-color/system-color-consistency-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-color/system-color-support-expected.txt
    M Source/WebCore/rendering/mac/RenderThemeMac.mm

  Log Message:
  -----------
  AX: ButtonFace color has bad contrast with ButtonText color in dark mode
https://bugs.webkit.org/show_bug.cgi?id=276476
rdar://131996608

Reviewed by Aditya Keerthi.

Use a system color in dark mode instead of a hardcoded light color.

* LayoutTests/imported/w3c/web-platform-tests/css/css-color/system-color-consistency-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-color/system-color-support-expected.txt:
* Source/WebCore/rendering/mac/RenderThemeMac.mm:
(WebCore::RenderThemeMac::systemColor const):

Canonical link: https://commits.webkit.org/283284@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list