[webkit-changes] [WebKit/WebKit] c2c4d7: Allow HTTPFallback for non-standard port

Commit Queue noreply at github.com
Fri Sep 6 16:23:43 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c2c4d7896d55367c9e7041af624454297226c8a9
      https://github.com/WebKit/WebKit/commit/c2c4d7896d55367c9e7041af624454297226c8a9
  Author: Matthew Finkel <m_finkel at apple.com>
  Date:   2024-09-06 (Fri, 06 Sep 2024)

  Changed paths:
    M Source/WebCore/platform/network/mac/ResourceErrorMac.mm
    M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp

  Log Message:
  -----------
  Allow HTTPFallback for non-standard port
https://bugs.webkit.org/show_bug.cgi?id=279282
rdar://problem/135439726

Reviewed by Alex Christensen.

Currently, we restrict allowing HTTPFallback to either the default HTTPS port
(443) or a non-standard default port that is configured for the webview. This
conflicts with other places in the logic where we allow optimistically
upgrading regardless of whether the port is consider the "default".

This patch also moves adjusting the request timeout earlier in
NetworkResourceLoader::startNetworkLoad so the existing logging correctly
captures the timeout value.

* Source/WebCore/platform/network/mac/ResourceErrorMac.mm:
(WebCore::ResourceError::errorRecoveryMethod const):
* Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::startNetworkLoad):

Canonical link: https://commits.webkit.org/283283@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list