[webkit-changes] [WebKit/WebKit] c36b50: [Part 4] All numeric CSSPrimitiveValue resolvers n...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c36b50dac0bc42ba7b8722b1d9fef3f24f19a5da
      https://github.com/WebKit/WebKit/commit/c36b50dac0bc42ba7b8722b1d9fef3f24f19a5da
  Author: Sam Weinig <sam at webkit.org>
  Date:   2024-09-06 (Fri, 06 Sep 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-area-computed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-area-computed.html
    M Source/WebCore/css/CSSGridLineValue.cpp
    M Source/WebCore/css/CSSGridLineValue.h
    M Source/WebCore/css/CSSProperties.json
    M Source/WebCore/rendering/style/RenderStyle.h
    M Source/WebCore/rendering/style/RenderStyleInlines.h
    M Source/WebCore/style/StyleBuilderConverter.h
    M Source/WebCore/style/StyleBuilderCustom.h

  Log Message:
  -----------
  [Part 4] All numeric CSSPrimitiveValue resolvers need to take CSSToLengthConversionData: grid-area
https://bugs.webkit.org/show_bug.cgi?id=279211

Reviewed by Darin Adler.

Pass conversion data to integer resolver for grid-area's integer value.

Also fixes up CSS grid BuilderConverter code a bit to:
    - Pass BuilderState as the first parameter
    - Use std::optional return type rather than an out parameter + bool for createGridTrackList.
      With that done, the entire builder implementation of GridTemplateColumns/GridTemplateRows
      could be replaced with generated conditional-converter code.
    - Use a normal return type rather than out parameter + bool for createGridPosition. It always
      return true, so it is also no longer a conditional-converter.
    - Use a normal return type for createImplicitNamedGridLinesFromGridArea. There was no reason
      for these to be out parameters.

* LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-area-computed-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-area-computed.html:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleInlines.h:
(WebCore::initialGridColumnList):
(WebCore::initialGridRowList):
* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertToRadiusLength):
(WebCore::Style::BuilderConverter::convertRadius):
(WebCore::Style::BuilderConverter::createGridTrackBreadth):
(WebCore::Style::BuilderConverter::createGridTrackSize):
(WebCore::Style::BuilderConverter::createGridTrackList):
(WebCore::Style::BuilderConverter::createGridPosition):
(WebCore::Style::BuilderConverter::createImplicitNamedGridLinesFromGridArea):
(WebCore::Style::BuilderConverter::convertGridTrackSize):
(WebCore::Style::BuilderConverter::convertGridTrackList):
(WebCore::Style::BuilderConverter::convertGridPosition):
* Source/WebCore/style/StyleBuilderCustom.h:
(WebCore::Style::BuilderCustom::applyValueGridTemplateAreas):
(WebCore::Style::BuilderCustom::applyInitialGridTemplateColumns): Deleted.
(WebCore::Style::BuilderCustom::applyInheritGridTemplateColumns): Deleted.
(WebCore::Style::BuilderCustom::applyValueGridTemplateColumns): Deleted.
(WebCore::Style::BuilderCustom::applyInitialGridTemplateRows): Deleted.
(WebCore::Style::BuilderCustom::applyInheritGridTemplateRows): Deleted.
(WebCore::Style::BuilderCustom::applyValueGridTemplateRows): Deleted.

Canonical link: https://commits.webkit.org/283285@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications