[webkit-changes] [WebKit/WebKit] 1bd2e3: Check ruby-position when checking for emphasis mar...

[fantasai]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1bd2e3ab2ace6e6d4776deaa96e0e8313c71f2dd
      https://github.com/WebKit/WebKit/commit/1bd2e3ab2ace6e6d4776deaa96e0e8313c71f2dd
  Author: Elika Etemad <fantasai.bugs at inkedblade.net>
  Date:   2024-09-06 (Fri, 06 Sep 2024)

  Changed paths:
    A LayoutTests/fast/text/emphasis-avoid-ruby-001-expected.txt
    A LayoutTests/fast/text/emphasis-avoid-ruby-001.html
    A LayoutTests/fast/text/emphasis-avoid-ruby-002-expected.html
    A LayoutTests/fast/text/emphasis-avoid-ruby-002.html
    R LayoutTests/fast/text/emphasis-avoid-ruby-expected.txt
    R LayoutTests/fast/text/emphasis-avoid-ruby.html
    M LayoutTests/platform/ios/TestExpectations
    M Source/WebCore/rendering/RenderText.cpp

  Log Message:
  -----------
  Check ruby-position when checking for emphasis mark / ruby conflicts
https://bugs.webkit.org/show_bug.cgi?id=279219
rdar://problem/135366189

Reviewed by Alan Baradlay.

Now that we support ruby-position, we need to check the position of the
annotation, not just assume that it is on the over side.

* LayoutTests/fast/text/emphasis-avoid-ruby-001-expected.txt: Renamed from LayoutTests/fast/text/emphasis-avoid-ruby-expected.txt.
* LayoutTests/fast/text/emphasis-avoid-ruby-001.html: Renamed from LayoutTests/fast/text/emphasis-avoid-ruby.html.
* LayoutTests/fast/text/emphasis-avoid-ruby-002-expected.html: Added.
* LayoutTests/fast/text/emphasis-avoid-ruby-002.html: Added.
* Source/WebCore/rendering/RenderText.cpp:
(WebCore::RenderText::emphasisMarkExistsAndIsAbove):

Canonical link: https://commits.webkit.org/283282@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications