[webkit-changes] [WebKit/WebKit] 8cc0d6: VoiceOver focus should be able to activate form fi...

Commit Queue noreply at github.com
Fri Sep 6 15:07:56 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8cc0d6f40b1648df767a36dc783368cde765bc0b
      https://github.com/WebKit/WebKit/commit/8cc0d6f40b1648df767a36dc783368cde765bc0b
  Author: Elina <elina.ding at apple.com>
  Date:   2024-09-06 (Fri, 06 Sep 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
    M Source/WebKit/WebProcess/Plugins/PDF/WKAccessibilityPDFDocumentObject.h
    M Source/WebKit/WebProcess/Plugins/PDF/WKAccessibilityPDFDocumentObject.mm

  Log Message:
  -----------
  VoiceOver focus should be able to activate form fields when it lands on them.
https://bugs.webkit.org/show_bug.cgi?id=278535
rdar://134522935

Reviewed by Abrar Rahman Protyasha.

Implement the annotation connection point between webkit and pdf in WKAccessibilityPDFDocumentObject.h. In this way, VoiceOver can activate form fields when it lands on form fields

* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:
(-[WKPDFPluginAccessibilityObject accessibilityAssociatedControlForAnnotation:]):
(WebKit::rectInViewSpaceForRectInLayoutSpace):
(WebKit::PDFPlugin::axObjectCache const): Deleted.
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::setActiveAnnotation):
* Source/WebKit/WebProcess/Plugins/PDF/WKAccessibilityPDFDocumentObject.h:
* Source/WebKit/WebProcess/Plugins/PDF/WKAccessibilityPDFDocumentObject.mm:
(-[WKAccessibilityPDFDocumentObject accessibilityAssociatedControlForAnnotation:]):
(-[WKAccessibilityPDFDocumentObject setActiveAnnotation:]):

Canonical link: https://commits.webkit.org/283281@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list