[webkit-changes] [WebKit/WebKit] 92b08e: MediaSource::m_private is accessed before initiali...

Sihui noreply at github.com
Thu Oct 31 14:03:30 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 92b08efceed7b8d85a725179fe4b95cb89fef698
      https://github.com/WebKit/WebKit/commit/92b08efceed7b8d85a725179fe4b95cb89fef698
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2024-10-31 (Thu, 31 Oct 2024)

  Changed paths:
    M Source/WebCore/Modules/mediasource/MediaSource.h

  Log Message:
  -----------
  MediaSource::m_private is accessed before initialization
https://bugs.webkit.org/show_bug.cgi?id=282365
rdar://138955983

Reviewed by Chris Dumez.

When MediaSource::m_client is initialized, MediaSourceClientImpl is constructed. The MediaSourceClientImpl constructor
reads parent.m_private, which is MediaSource::m_private; but MediaSource::m_private is undefined as it is initailized
after MediaSource::m_client. To fix this, ensure m_private is initialized before m_client in MediaSource.

* Source/WebCore/Modules/mediasource/MediaSource.h:

Canonical link: https://commits.webkit.org/285977@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list