[webkit-changes] [WebKit/WebKit] b235c7: Change environment map data variable names to more...

Alex Marchenko noreply at github.com
Thu Oct 31 14:01:13 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b235c73174d04725454884e4f80df87a0a67a0de
      https://github.com/WebKit/WebKit/commit/b235c73174d04725454884e4f80df87a0a67a0de
  Author: Aleksei Marchenko <aleksei at apple.com>
  Date:   2024-10-31 (Thu, 31 Oct 2024)

  Changed paths:
    M Source/WebCore/Modules/model-element/HTMLModelElement.cpp
    M Source/WebCore/Modules/model-element/HTMLModelElement.h
    M Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.h
    M Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm

  Log Message:
  -----------
  Change environment map data variable names to more descriptive ones.
https://bugs.webkit.org/show_bug.cgi?id=282355
rdar://138945410

Reviewed by Ada Chan.

A follow up change to redeem unintentional renaming that happened in the
initial implementation.

* Source/WebCore/Modules/model-element/HTMLModelElement.cpp:
(WebCore::HTMLModelElement::dataReceived):
(WebCore::HTMLModelElement::createModelPlayer):
(WebCore::HTMLModelElement::environmentMapRequestResource):
(WebCore::HTMLModelElement::environmentMapResetAndReject):
(WebCore::HTMLModelElement::environmentMapResourceFinished):
* Source/WebCore/Modules/model-element/HTMLModelElement.h:
* Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.h:
* Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm:
(WebKit::ModelProcessModelPlayerProxy::setEnvironmentMap):
(WebKit::ModelProcessModelPlayerProxy::applyEnvironmentMapDataAndRelease):

Canonical link: https://commits.webkit.org/285976@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list