[webkit-changes] [WebKit/WebKit] 2c059e: RenderViewTransitionCapture unconditionally alloca...

[mattwoodrow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2c059ec5441d7d1553910f1224059f9a28b28ec3
      https://github.com/WebKit/WebKit/commit/2c059ec5441d7d1553910f1224059f9a28b28ec3
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2024-10-31 (Thu, 31 Oct 2024)

  Changed paths:
    A LayoutTests/fast/css/view-transitions-no-content-for-new-pseudo-expected.txt
    A LayoutTests/fast/css/view-transitions-no-content-for-new-pseudo.html
    A LayoutTests/platform/mac-wk1/fast/css/view-transitions-no-content-for-new-pseudo-expected.txt
    M LayoutTests/platform/win/TestExpectations
    M Source/WebCore/rendering/RenderEmbeddedObject.cpp
    M Source/WebCore/rendering/RenderEmbeddedObject.h
    M Source/WebCore/rendering/RenderLayerBacking.cpp
    M Source/WebCore/rendering/RenderReplaced.h
    M Source/WebCore/rendering/RenderViewTransitionCapture.cpp
    M Source/WebCore/rendering/RenderViewTransitionCapture.h

  Log Message:
  -----------
  RenderViewTransitionCapture unconditionally allocates a backing store.
https://bugs.webkit.org/show_bug.cgi?id=282077
<rdar://138601957>

Reviewed by Tim Nguyen.

The RenderLayerBacking for RenderViewTransitionCapture always allocates a
backing store, since isSimpleContainerCompositingLayer always returns false for
RenderReplaced subclasses.

When being used for a ::view-transition-new() pseudo element, this layer just
exists to attach other composited layers to, and doesn't draw anything itself
(unless it has box decorations etc).

* LayoutTests/fast/css/view-transitions-no-content-for-new-pseudo-expected.txt: Added.
* LayoutTests/fast/css/view-transitions-no-content-for-new-pseudo.html: Added.
* Source/WebCore/rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::paintsContent const):
* Source/WebCore/rendering/RenderEmbeddedObject.h:
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer const):
(WebCore::isCompositedPlugin): Deleted.
* Source/WebCore/rendering/RenderReplaced.h:
(WebCore::RenderReplaced::paintsContent const):
* Source/WebCore/rendering/RenderViewTransitionCapture.cpp:
(WebCore::RenderViewTransitionCapture::paintsContent const):
* Source/WebCore/rendering/RenderViewTransitionCapture.h:

Canonical link: https://commits.webkit.org/285978@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications