[webkit-changes] [WebKit/WebKit] 9517ef: [css-masonry] Revert Rows 005 Fix

Brandon Stewart noreply at github.com
Thu Oct 31 13:53:12 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9517efe03711bfecaa84e3aa3ec8174b75666698
      https://github.com/WebKit/WebKit/commit/9517efe03711bfecaa84e3aa3ec8174b75666698
  Author: Brandon Stewart <brandonstewart at apple.com>
  Date:   2024-10-31 (Thu, 31 Oct 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-rows-005-expected.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-rows-005-ref.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-rows-005.html

  Log Message:
  -----------
  [css-masonry] Revert Rows 005 Fix
https://bugs.webkit.org/show_bug.cgi?id=282397
rdar://problem/139013428

Reviewed by Sammy Gill.

Based on discussions with Sammy and Elika I believe my updates to the rows 005 test case are not correct.
The width sizing was correct, and we should not be adding the extra padding at the end.

Reverts: https://github.com/WebKit/WebKit/commit/b79f7439f9580da79e784a83279751fecbb1e401

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-rows-005-expected.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-rows-005-ref.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-rows-005.html:

Canonical link: https://commits.webkit.org/285975@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list