[webkit-changes] [WebKit/WebKit] e2cc52: [JSC] add support for `Iterator.concat`

Devin Rousso noreply at github.com
Tue Oct 22 21:46:50 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e2cc521c373c50c6048391237658c08a00973f35
      https://github.com/WebKit/WebKit/commit/e2cc521c373c50c6048391237658c08a00973f35
  Author: Devin Rousso <hi at devinrousso.com>
  Date:   2024-10-22 (Tue, 22 Oct 2024)

  Changed paths:
    A JSTests/stress/iterator-concat.js
    M Source/JavaScriptCore/builtins/JSIteratorConstructor.js
    M Source/JavaScriptCore/builtins/JSIteratorHelperPrototype.js
    M Source/JavaScriptCore/runtime/JSIteratorConstructor.cpp
    M Source/JavaScriptCore/runtime/OptionsList.h

  Log Message:
  -----------
  [JSC] add support for `Iterator.concat`
https://bugs.webkit.org/show_bug.cgi?id=281109

Reviewed by Alexey Shvayka.

This will allow for easier composition of iterators instead of having to manually create a generator or spread into an array.

Proposal: <https://github.com/tc39/proposal-iterator-sequencing>
Spec: <https://tc39.es/proposal-iterator-sequencing/>

* Source/JavaScriptCore/builtins/JSIteratorConstructor.js:
(concat): Added.
* Source/JavaScriptCore/runtime/JSIteratorConstructor.cpp:
(JSC::JSIteratorConstructor::finishCreation):
* Source/JavaScriptCore/runtime/OptionsList.h:

* Source/JavaScriptCore/builtins/JSIteratorHelperPrototype.js:
(return):
Check if the `UnderlyingIterator` is null (in the case of `Iterator.concat`) before attempting to close it.

* JSTests/stress/iterator-concat.js: Added.

Canonical link: https://commits.webkit.org/285587@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list