[webkit-changes] [WebKit/WebKit] 46d880: Regression(283950 at main): Crash in WebCore::Inspect...

[Qianlang Chen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 46d8803827ef233fd7572a5259097a95328ab007
      https://github.com/WebKit/WebKit/commit/46d8803827ef233fd7572a5259097a95328ab007
  Author: Qianlang Chen <qianlangchen at apple.com>
  Date:   2024-10-22 (Tue, 22 Oct 2024)

  Changed paths:
    M Source/WebCore/inspector/InspectorStyleSheet.cpp

  Log Message:
  -----------
  Regression(283950 at main): Crash in WebCore::InspectorStyleSheet::setRuleStyleText
rdar://138232398
https://bugs.webkit.org/show_bug.cgi?id=281807

Reviewed by Chris Dumez.

* Source/WebCore/inspector/InspectorStyleSheet.cpp:
(WebCore::computeCanonicalRuleText):
(WebCore::InspectorStyleSheet::setRuleStyleText):
   - When writing the helper `computeCanonicalRuleText`, returning a
     StringView was incorrect. A String should be returned to properly
     pass ownership of the underlying data.
   - This change can be tested with
         run-webkit-tests -g LayoutTests/inspector/css/setStyleText.html

Canonical link: https://commits.webkit.org/285588@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications