[webkit-changes] [WebKit/WebKit] 2d34e9: [WebAuthn] Reject empty appid extension

Abigail Fox noreply at github.com
Fri May 24 12:01:24 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2d34e99f4cc7519b2eab94842591b2b4df6ab653
      https://github.com/WebKit/WebKit/commit/2d34e99f4cc7519b2eab94842591b2b4df6ab653
  Author: Abigail Fox <abigail_fox at apple.com>
  Date:   2024-05-24 (Fri, 24 May 2024)

  Changed paths:
    M LayoutTests/http/wpt/webauthn/public-key-credential-get-failure-hid-silent.https-expected.txt
    M LayoutTests/http/wpt/webauthn/public-key-credential-get-failure-hid-silent.https.html
    M LayoutTests/http/wpt/webauthn/public-key-credential-get-failure-u2f.https-expected.txt
    M LayoutTests/http/wpt/webauthn/public-key-credential-get-failure-u2f.https.html
    M Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp

  Log Message:
  -----------
  [WebAuthn] Reject empty appid extension
https://bugs.webkit.org/show_bug.cgi?id=272531
rdar://90281712

Reviewed by Pascoe.

Return a NotSupportedError when appid extension is empty, to match WPT test expectations

* LayoutTests/http/wpt/webauthn/public-key-credential-get-failure-hid-silent.https-expected.txt:
* LayoutTests/http/wpt/webauthn/public-key-credential-get-failure-hid-silent.https.html:
* LayoutTests/http/wpt/webauthn/public-key-credential-get-failure-u2f.https-expected.txt:
* LayoutTests/http/wpt/webauthn/public-key-credential-get-failure-u2f.https.html:
* Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:
(WebCore::AuthenticatorCoordinator::create):
(WebCore::AuthenticatorCoordinator::discoverFromExternalSource):

Canonical link: https://commits.webkit.org/279285@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list