[webkit-changes] [WebKit/WebKit] 93f762: [WebGPU] RenderPassEncoder::errorValidatingDrawInd...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 93f762e0815d769aa5730b0e78f946178770b54f
      https://github.com/WebKit/WebKit/commit/93f762e0815d769aa5730b0e78f946178770b54f
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-05-24 (Fri, 24 May 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    A LayoutTests/fast/webgpu/fuzz-274622-expected.txt
    A LayoutTests/fast/webgpu/fuzz-274622.html
    M Source/WebGPU/WebGPU/RenderBundleEncoder.h
    M Source/WebGPU/WebGPU/RenderBundleEncoder.mm
    M Source/WebGPU/WebGPU/RenderPassEncoder.mm

  Log Message:
  -----------
  [WebGPU] RenderPassEncoder::errorValidatingDrawIndexed accesses m_pipeline without checking if it exists
https://bugs.webkit.org/show_bug.cgi?id=274622
<radar://128640505>

Reviewed by Tadeu Zagallo.

m_pipeline may be null, need to check it before accessing the WeakPtr.

* LayoutTests/TestExpectations:
* LayoutTests/fast/webgpu/fuzz-274622-expected.txt: Added.
* LayoutTests/fast/webgpu/fuzz-274622.html: Added.
Add regression test.

* Source/WebGPU/WebGPU/RenderBundleEncoder.h:
* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(WebGPU::RenderBundleEncoder::computeMininumVertexCount const):
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::computeMininumVertexCount const):
(WebGPU::RenderPassEncoder::clampIndexBufferToValidValues):
(WebGPU::RenderPassEncoder::clampIndirectIndexBufferToValidValues):
(WebGPU::RenderPassEncoder::errorValidatingDrawIndexed const):

Canonical link: https://commits.webkit.org/279284@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications