[webkit-changes] [WebKit/WebKit] a7729f: Potential UIProcess hang under WebsiteDataStore::r...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a7729f2954c97bcf3efcd9393e1fd50d1c46dcf9
      https://github.com/WebKit/WebKit/commit/a7729f2954c97bcf3efcd9393e1fd50d1c46dcf9
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-05-24 (Fri, 24 May 2024)

  Changed paths:
    M Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm

  Log Message:
  -----------
  Potential UIProcess hang under WebsiteDataStore::removeDataStoreWithIdentifier()
https://bugs.webkit.org/show_bug.cgi?id=274660
rdar://128537723

Reviewed by Per Arne Vollan.

The hang was happening under `[nsCredentialStorage allCredentials]`. This patches
moves some of the logic to the background queue to avoid hanging the UIProcess'
main thread when the operation is slow. I have verified with the CFNetwork team
that it is safe to use this API on a background thread.

* Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::removeDataStoreWithIdentifier):

Canonical link: https://commits.webkit.org/279286@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications