[webkit-changes] [WebKit/WebKit] 19ba6b: [Site Isolation] Fix TestWebKitAPI.ProcessSwap.DoS...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 19ba6b94a4cb542a2f2837ca9341d7f910ce5775
      https://github.com/WebKit/WebKit/commit/19ba6b94a4cb542a2f2837ca9341d7f910ce5775
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-05-13 (Mon, 13 May 2024)

  Changed paths:
    M Source/WebKit/UIProcess/WebPageProxy.cpp

  Log Message:
  -----------
  [Site Isolation] Fix TestWebKitAPI.ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted after 278624 at main
https://bugs.webkit.org/show_bug.cgi?id=274126
rdar://128023861

Reviewed by Charlie Wolfe.

I added an early return in WebPageProxy::didStartProvisionalLoadForFrameShared that I thought would only affect
behavior with site isolation on.  The assertion is hit with site isolation off, so for now just guard the behavior
change with a check to whether site isolation is on.  That fixes the regression.  When I get time to investigate
I'll see what the correct thing to do in this case with site isolation on is.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didStartProvisionalLoadForFrameShared):

Canonical link: https://commits.webkit.org/278716@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications