[webkit-changes] [WebKit/WebKit] 741a87: [webkitscmpy] Fix BitBucket inline comments for ad...

Jonathan Bedard noreply at github.com
Mon May 13 15:58:53 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 741a871d17464fde986045793a3c0be5bb40f277
      https://github.com/WebKit/WebKit/commit/741a871d17464fde986045793a3c0be5bb40f277
  Author: Jonathan Bedard <jbedard at apple.com>
  Date:   2024-05-13 (Mon, 13 May 2024)

  Changed paths:
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/bitbucket.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/bitbucket.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py

  Log Message:
  -----------
  [webkitscmpy] Fix BitBucket inline comments for added files
https://bugs.webkit.org/show_bug.cgi?id=274100
rdar://128012248

Reviewed by Dewei Zhu.

When adding a new file, the "source" file won't exist in BitBucket's diff response.

* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/bitbucket.py:
(BitBucket.request):
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/bitbucket.py:
(BitBucket.PRGenerator._position_converters): Handle case where source or destination don't exist.
(BitBucket.json_to_diff): Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:

Canonical link: https://commits.webkit.org/278717@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list