[webkit-changes] [WebKit/WebKit] 199873: Present AppSSO on the top-most presentedViewContro...

Commit Queue noreply at github.com
Mon May 13 15:13:47 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 19987381048be471e9b1bbf2b676a97c95098fbd
      https://github.com/WebKit/WebKit/commit/19987381048be471e9b1bbf2b676a97c95098fbd
  Author: Pascoe <pascoe at apple.com>
  Date:   2024-05-13 (Mon, 13 May 2024)

  Changed paths:
    M Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm

  Log Message:
  -----------
  Present AppSSO on the top-most presentedViewController
https://bugs.webkit.org/show_bug.cgi?id=274028
rdar://127761880

Reviewed by Aditya Keerthi.

In some situations AppSSO will be called where the result of [m_page->cocoaView() window].rootViewController
is not applicable to present a view controller on top of because it's already presenting something. To fix
this we can look at the top-most presentedViewController of [m_page->cocoaView() window].rootViewController.

* Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm:
(WebKit::SOAuthorizationSession::presentViewController):

Canonical link: https://commits.webkit.org/278715@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list