[webkit-changes] [WebKit/WebKit] ea3f57: REGRESSION (259678 at main): [ iOS17 ] ASSERTION FAIL...

Chris Dumez noreply at github.com
Thu Jan 25 23:35:29 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ea3f579227de9f2371cc2dca298842a51f45ddf9
      https://github.com/WebKit/WebKit/commit/ea3f579227de9f2371cc2dca298842a51f45ddf9
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-01-25 (Thu, 25 Jan 2024)

  Changed paths:
    M LayoutTests/platform/ios-wk2/TestExpectations
    M Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm

  Log Message:
  -----------
  REGRESSION (259678 at main): [ iOS17 ] ASSERTION FAILED: task.callback for fast/dom/Orientation/no-orientation-change-event-when-unparenting-view.html result of a consistent crash
https://bugs.webkit.org/show_bug.cgi?id=267934
rdar://121454476

Reviewed by Ryosuke Niwa.

Make sure we clear the `rotationDidEndCallback` delegate on the WKWebView once
it has been called. Otherwise, we may end up trying to call the callback several
times, which would hit the assertion we were seeing.

* LayoutTests/platform/ios-wk2/TestExpectations:
* Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptControllerIOS::simulateRotation):

Canonical link: https://commits.webkit.org/273552@main




More information about the webkit-changes mailing list