[webkit-changes] [WebKit/WebKit] 546557: Crash under SubresourceLoader::didReceiveBuffer()

Chris Dumez noreply at github.com
Fri Jan 26 00:11:25 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 546557ed3114bc86c74154a225f7f1605f0a63cb
      https://github.com/WebKit/WebKit/commit/546557ed3114bc86c74154a225f7f1605f0a63cb
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-01-26 (Fri, 26 Jan 2024)

  Changed paths:
    M Source/WebCore/loader/SubresourceLoader.cpp
    M Source/WebCore/loader/SubresourceLoader.h

  Log Message:
  -----------
  Crash under SubresourceLoader::didReceiveBuffer()
https://bugs.webkit.org/show_bug.cgi?id=266589
rdar://116974951

Reviewed by Ryosuke Niwa.

Make sure we protect the CachedResource before calling non-trivial member
functions on it.

* Source/WebCore/loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequestInternal):
(WebCore::SubresourceLoader::didSendData):
(WebCore::SubresourceLoader::didReceivePreviewResponse):
(WebCore::SubresourceLoader::didReceiveResponse):
(WebCore::SubresourceLoader::didReceiveBuffer):
(WebCore::SubresourceLoader::willCancel):
(WebCore::SubresourceLoader::didCancel):
(WebCore::SubresourceLoader::releaseResources):
* Source/WebCore/loader/SubresourceLoader.h:

Originally-landed-as: 267815.652 at safari-7617-branch (ea99166b2dfe). rdar://121478300
Canonical link: https://commits.webkit.org/273553@main




More information about the webkit-changes mailing list