[webkit-changes] [WebKit/WebKit] 7719c4: [masonry] Update to modern track sizing algorithm ...

Brandon Stewart noreply at github.com
Thu Jan 25 22:35:25 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7719c4262533e0ce345feda9d30c9b399ec4efbd
      https://github.com/WebKit/WebKit/commit/7719c4262533e0ce345feda9d30c9b399ec4efbd
  Author: Brandon Stewart <brandonstewart at apple.com>
  Date:   2024-01-25 (Thu, 25 Jan 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/gap/masonry-gap-001-expected.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/gap/masonry-gap-001-ref.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/gap/masonry-gap-001.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-left-side-expected.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-left-side-ref.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-right-side-expected.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-right-side-ref.html
    M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp

  Log Message:
  -----------
  [masonry] Update to modern track sizing algorithm during accumulating track sizes
https://bugs.webkit.org/show_bug.cgi?id=268050

Reviewed by Sammy Gill.

Update to the new track sizing algorithm. All elements participate that are definite inside the track,
and those that are indefinite.

This patch only handles the algorithm. Another patch will handle placing all indefinite items across
all intrinsic tracks.

Test Case Updates:

masonry-track-sizing-overflow-left/right-side:
These test cases were built off the idea of the old track sizing algorithm where only the first track determined the
column size. Under the new algorithm all items now contribute; therefore the bottom item extends the track an extra 50px.

masonry-gap-001:
Simplified test case to focus on the gap.
Updated the grid-columns for items to ensure that other tracks would not affect the 2nd column.

* LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/gap/masonry-gap-001-expected.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/gap/masonry-gap-001-ref.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/gap/masonry-gap-001.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-left-side-expected.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-left-side-ref.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-right-side-expected.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-right-side-ref.html:
* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithm::accumulateIntrinsicSizesForTrack):

Canonical link: https://commits.webkit.org/273551@main




More information about the webkit-changes mailing list