[webkit-changes] [WebKit/WebKit] 8c2f91: [WGSL] webgpu:shader, execution, robust_access:* is ...
Tadeu Zagallo
noreply at github.com
Fri Jan 19 08:25:32 PST 2024
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8c2f912a0edfdb7d2833a620529a49a589711a34
https://github.com/WebKit/WebKit/commit/8c2f912a0edfdb7d2833a620529a49a589711a34
Author: Tadeu Zagallo <tzagallo at apple.com>
Date: 2024-01-19 (Fri, 19 Jan 2024)
Changed paths:
M Source/WebGPU/WGSL/TypeCheck.cpp
Log Message:
-----------
[WGSL] webgpu:shader,execution,robust_access:* is crashing
https://bugs.webkit.org/show_bug.cgi?id=267721
rdar://121209161
Reviewed by Mike Wyrzykowski.
The global variable rewriter assumes that all global variables will have a reference
type, but the type checker was not creating reference types for variable that did not
have a type annotation, which is valid for global variables in the private address
space. This isn't enough to make the test pass, but it no longer crashes.
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visitVariable):
Canonical link: https://commits.webkit.org/273220@main
More information about the webkit-changes
mailing list