[webkit-changes] [WebKit/WebKit] e00eb7: [WGSL] shader, execution, shader_io, compute_builtins...

Tadeu Zagallo noreply at github.com
Fri Jan 19 07:46:39 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e00eb7be3a35d71e9afbeae7512f10b3b8d5a941
      https://github.com/WebKit/WebKit/commit/e00eb7be3a35d71e9afbeae7512f10b3b8d5a941
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-01-19 (Fri, 19 Jan 2024)

  Changed paths:
    M Source/WebGPU/WGSL/EntryPointRewriter.cpp

  Log Message:
  -----------
  [WGSL] shader,execution,shader_io,compute_builtins:* is failing
https://bugs.webkit.org/show_bug.cgi?id=267717
rdar://121207920

Reviewed by Mike Wyrzykowski.

When rewriting entry points to move builtin arguments from structs into top level
parameters we were using the name of the struct field. However, field names are
only unique within the struct, so when extracting fields from multiple structs they
could clash. In order to fix that we generate a new unique name for the parameter,
instead of using the name of the struct field. This doesn't affect the rest of the
program, since we reconstruct the struct anyway.

* Source/WebGPU/WGSL/EntryPointRewriter.cpp:
(WGSL::EntryPointRewriter::materialize):
(WGSL::EntryPointRewriter::visit):

Canonical link: https://commits.webkit.org/273219@main




More information about the webkit-changes mailing list