[webkit-changes] [WebKit/WebKit] ae031c: [JSC] use UNLIKELY in Intl APIs for rare cases

Commit Queue noreply at github.com
Fri Jan 19 09:31:05 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ae031c19c82f8e1e84539b22c3547b035e4d55e4
      https://github.com/WebKit/WebKit/commit/ae031c19c82f8e1e84539b22c3547b035e4d55e4
  Author: Yijia Huang <yijia_huang at apple.com>
  Date:   2024-01-19 (Fri, 19 Jan 2024)

  Changed paths:
    M Source/JavaScriptCore/runtime/IntlCollatorPrototype.cpp
    M Source/JavaScriptCore/runtime/IntlDisplayNamesPrototype.cpp
    M Source/JavaScriptCore/runtime/IntlDurationFormatPrototype.cpp
    M Source/JavaScriptCore/runtime/IntlListFormatPrototype.cpp
    M Source/JavaScriptCore/runtime/IntlLocalePrototype.cpp
    M Source/JavaScriptCore/runtime/IntlPluralRulesPrototype.cpp
    M Source/JavaScriptCore/runtime/IntlRelativeTimeFormatPrototype.cpp
    M Source/JavaScriptCore/runtime/IntlSegmentIteratorPrototype.cpp
    M Source/JavaScriptCore/runtime/IntlSegmenterPrototype.cpp
    M Source/JavaScriptCore/runtime/IntlSegmentsPrototype.cpp

  Log Message:
  -----------
  [JSC] use UNLIKELY in Intl APIs for rare cases
https://bugs.webkit.org/show_bug.cgi?id=267738
rdar://121221571

Reviewed by Alexey Shvayka and Justin Michaud.

The case that CallFrame's `this` is not the desired object
is rare, so we should use `UNLIKELY` for them in Intl APIs.

* Source/JavaScriptCore/runtime/IntlCollatorPrototype.cpp:
(JSC::JSC_DEFINE_CUSTOM_GETTER):
(JSC::JSC_DEFINE_HOST_FUNCTION):
* Source/JavaScriptCore/runtime/IntlDisplayNamesPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
* Source/JavaScriptCore/runtime/IntlDurationFormatPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
* Source/JavaScriptCore/runtime/IntlListFormatPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
* Source/JavaScriptCore/runtime/IntlLocalePrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::JSC_DEFINE_CUSTOM_GETTER):
* Source/JavaScriptCore/runtime/IntlPluralRulesPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
* Source/JavaScriptCore/runtime/IntlRelativeTimeFormatPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
* Source/JavaScriptCore/runtime/IntlSegmentIteratorPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
* Source/JavaScriptCore/runtime/IntlSegmenterPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
* Source/JavaScriptCore/runtime/IntlSegmentsPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):

Canonical link: https://commits.webkit.org/273221@main




More information about the webkit-changes mailing list