[webkit-changes] [WebKit/WebKit] 3636ca: Rename `ShadowPseudoIds` to `UserAgentPartIds`

Tim Nguyen noreply at github.com
Tue Jan 2 23:39:01 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3636ca91f8a119ffae44cef492efd8fbaefe703a
      https://github.com/WebKit/WebKit/commit/3636ca91f8a119ffae44cef492efd8fbaefe703a
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2024-01-02 (Tue, 02 Jan 2024)

  Changed paths:
    M LayoutTests/fast/dom/HTMLMeterElement/meter-clone-expected.txt
    M LayoutTests/fast/dom/HTMLMeterElement/meter-clone.html
    M LayoutTests/fast/dom/HTMLProgressElement/progress-clone-expected.txt
    M LayoutTests/fast/dom/HTMLProgressElement/progress-clone.html
    M LayoutTests/fast/dom/nodesFromRect/resources/nodesFromRect.js
    M LayoutTests/fast/forms/resources/common.js
    M LayoutTests/fast/forms/validation-message-clone-expected.txt
    M LayoutTests/fast/forms/validation-message-clone.html
    M LayoutTests/fast/html/clone-range-expected.txt
    M LayoutTests/fast/html/clone-range.html
    M LayoutTests/fast/html/details-clone.html
    M LayoutTests/platform/ios/ios/plugin/youtube-flash-plugin-iframe-expected.txt
    M LayoutTests/platform/ios/ios/plugin/youtube-flash-plugin-iframe.html
    M LayoutTests/plugins/quicktime-plugin-replacement-expected.txt
    M LayoutTests/plugins/quicktime-plugin-replacement.html
    M LayoutTests/resources/dump-as-markup.js
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/css/SelectorChecker.cpp
    M Source/WebCore/dom/Element.cpp
    M Source/WebCore/dom/Element.h
    M Source/WebCore/dom/mac/ImageControlsMac.cpp
    M Source/WebCore/html/BaseDateAndTimeInputType.cpp
    M Source/WebCore/html/ColorInputType.cpp
    M Source/WebCore/html/FileInputType.cpp
    M Source/WebCore/html/HTMLMeterElement.cpp
    M Source/WebCore/html/RangeInputType.cpp
    M Source/WebCore/html/SearchInputType.cpp
    M Source/WebCore/html/TextFieldInputType.cpp
    M Source/WebCore/html/ValidationMessage.cpp
    M Source/WebCore/html/shadow/DateTimeEditElement.cpp
    M Source/WebCore/html/shadow/DateTimeFieldElements.cpp
    M Source/WebCore/html/shadow/DetailsMarkerControl.cpp
    M Source/WebCore/html/shadow/MediaControlTextTrackContainerElement.cpp
    M Source/WebCore/html/shadow/ProgressShadowElement.cpp
    R Source/WebCore/html/shadow/ShadowPseudoIds.cpp
    R Source/WebCore/html/shadow/ShadowPseudoIds.h
    M Source/WebCore/html/shadow/SliderThumbElement.cpp
    M Source/WebCore/html/shadow/SliderThumbElement.h
    M Source/WebCore/html/shadow/SpinButtonElement.cpp
    M Source/WebCore/html/shadow/SwitchThumbElement.cpp
    M Source/WebCore/html/shadow/SwitchTrackElement.cpp
    M Source/WebCore/html/shadow/TextControlInnerElements.cpp
    A Source/WebCore/html/shadow/UserAgentPartIds.cpp
    A Source/WebCore/html/shadow/UserAgentPartIds.h
    M Source/WebCore/html/shadow/YouTubeEmbedShadowElement.cpp
    M Source/WebCore/html/track/TextTrackCue.cpp
    M Source/WebCore/html/track/VTTCue.cpp
    M Source/WebCore/html/track/VTTRegion.cpp
    M Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp
    M Source/WebCore/rendering/RenderTheme.cpp
    M Source/WebCore/style/ElementRuleCollector.cpp
    M Source/WebCore/style/RuleData.cpp
    M Source/WebCore/style/StyleAdjuster.cpp
    M Source/WebCore/style/StyleInvalidator.cpp
    M Source/WebCore/style/StyleResolver.cpp
    M Source/WebCore/style/StyleSharingResolver.cpp
    M Source/WebCore/testing/Internals.cpp
    M Source/WebCore/testing/Internals.h
    M Source/WebCore/testing/Internals.idl

  Log Message:
  -----------
  Rename `ShadowPseudoIds` to `UserAgentPartIds`
https://bugs.webkit.org/show_bug.cgi?id=267019
rdar://120397425

Reviewed by Ryosuke Niwa.

Make it consistent with the new naming introduced in bug 267016.

* LayoutTests/fast/dom/HTMLMeterElement/meter-clone-expected.txt:
* LayoutTests/fast/dom/HTMLMeterElement/meter-clone.html:
* LayoutTests/fast/dom/HTMLProgressElement/progress-clone-expected.txt:
* LayoutTests/fast/dom/HTMLProgressElement/progress-clone.html:
* LayoutTests/fast/dom/nodesFromRect/resources/nodesFromRect.js:
(checkShadowContent):
* LayoutTests/fast/forms/resources/common.js:
(getElementByPseudoId):
* LayoutTests/fast/forms/validation-message-clone-expected.txt:
* LayoutTests/fast/forms/validation-message-clone.html:
* LayoutTests/fast/html/clone-range-expected.txt:
* LayoutTests/fast/html/clone-range.html:
* LayoutTests/fast/html/details-clone.html:
* LayoutTests/platform/ios/ios/plugin/youtube-flash-plugin-iframe-expected.txt:
* LayoutTests/platform/ios/ios/plugin/youtube-flash-plugin-iframe.html:
* LayoutTests/plugins/quicktime-plugin-replacement-expected.txt:
* LayoutTests/plugins/quicktime-plugin-replacement.html:
* LayoutTests/resources/dump-as-markup.js:
(Markup._get):
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/SelectorChecker.cpp:
(WebCore::SelectorChecker::matchRecursively const):
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::userAgentPartId const):
(WebCore::Element::shadowPseudoId const): Deleted.
* Source/WebCore/dom/Element.h:
* Source/WebCore/dom/mac/ImageControlsMac.cpp:
(WebCore::ImageControlsMac::createImageControls):
* Source/WebCore/html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::createShadowSubtree):
* Source/WebCore/html/ColorInputType.cpp:
(WebCore::ColorInputType::createShadowSubtree):
* Source/WebCore/html/FileInputType.cpp:
(WebCore::FileInputType::createShadowSubtree):
* Source/WebCore/html/HTMLMeterElement.cpp:
(WebCore::setValueClass):
(WebCore::HTMLMeterElement::didAddUserAgentShadowRoot):
* Source/WebCore/html/RangeInputType.cpp:
(WebCore::RangeInputType::createShadowSubtree):
* Source/WebCore/html/SearchInputType.cpp:
(WebCore::updateResultButtonPseudoType):
* Source/WebCore/html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::createDataListDropdownIndicator):
(WebCore::autoFillButtonTypeToAutoFillButtonPseudoClassName):
(WebCore::isAutoFillButtonTypeChanged):
(WebCore::TextFieldInputType::createContainer):
* Source/WebCore/html/ValidationMessage.cpp:
(WebCore::ValidationMessage::buildBubbleTree):
* Source/WebCore/html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditBuilder::visitLiteral):
(WebCore::DateTimeEditElement::create):
(WebCore::DateTimeEditElement::layout):
* Source/WebCore/html/shadow/DateTimeFieldElements.cpp:
(WebCore::DateTimeDayFieldElement::create):
(WebCore::DateTimeHourFieldElement::create):
(WebCore::DateTimeMeridiemFieldElement::create):
(WebCore::DateTimeMillisecondFieldElement::create):
(WebCore::DateTimeMinuteFieldElement::create):
(WebCore::DateTimeMonthFieldElement::create):
(WebCore::DateTimeSecondFieldElement::create):
(WebCore::DateTimeSymbolicMonthFieldElement::create):
(WebCore::DateTimeYearFieldElement::create):
* Source/WebCore/html/shadow/DetailsMarkerControl.cpp:
(WebCore::DetailsMarkerControl::create):
* Source/WebCore/html/shadow/MediaControlTextTrackContainerElement.cpp:
(WebCore::MediaControlTextTrackContainerElement::create):
* Source/WebCore/html/shadow/ProgressShadowElement.cpp:
(WebCore::ProgressInnerElement::create):
(WebCore::ProgressBarElement::create):
(WebCore::ProgressValueElement::create):
* Source/WebCore/html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::create):
(WebCore::SliderContainerElement::create):
* Source/WebCore/html/shadow/SliderThumbElement.h:
* Source/WebCore/html/shadow/SpinButtonElement.cpp:
(WebCore::SpinButtonElement::create):
* Source/WebCore/html/shadow/SwitchThumbElement.cpp:
(WebCore::SwitchThumbElement::create):
* Source/WebCore/html/shadow/SwitchTrackElement.cpp:
(WebCore::SwitchTrackElement::create):
* Source/WebCore/html/shadow/TextControlInnerElements.cpp:
(WebCore::TextControlPlaceholderElement::create):
(WebCore::SearchFieldCancelButtonElement::create):
* Source/WebCore/html/shadow/UserAgentPartIds.cpp: Renamed from Source/WebCore/html/shadow/ShadowPseudoIds.cpp.
(WebCore::UserAgentPartIds::cue):
(WebCore::UserAgentPartIds::fileSelectorButton):
(WebCore::UserAgentPartIds::placeholder):
(WebCore::UserAgentPartIds::thumb):
(WebCore::UserAgentPartIds::track):
(WebCore::UserAgentPartIds::webkitContactsAutoFillButton):
(WebCore::UserAgentPartIds::webkitCredentialsAutoFillButton):
(WebCore::UserAgentPartIds::webkitCreditCardAutoFillButton):
(WebCore::UserAgentPartIds::webkitLoadingAutoFillButton):
(WebCore::UserAgentPartIds::webkitStrongPasswordAutoFillButton):
(WebCore::UserAgentPartIds::webkitCapsLockIndicator):
(WebCore::UserAgentPartIds::webkitColorSwatch):
(WebCore::UserAgentPartIds::webkitColorSwatchWrapper):
(WebCore::UserAgentPartIds::webkitDateAndTimeValue):
(WebCore::UserAgentPartIds::webkitDatetimeEdit):
(WebCore::UserAgentPartIds::webkitDatetimeEditDayField):
(WebCore::UserAgentPartIds::webkitDatetimeEditFieldsWrapper):
(WebCore::UserAgentPartIds::webkitDatetimeEditHourField):
(WebCore::UserAgentPartIds::webkitDatetimeEditMeridiemField):
(WebCore::UserAgentPartIds::webkitDatetimeEditMillisecondField):
(WebCore::UserAgentPartIds::webkitDatetimeEditMinuteField):
(WebCore::UserAgentPartIds::webkitDatetimeEditMonthField):
(WebCore::UserAgentPartIds::webkitDatetimeEditSecondField):
(WebCore::UserAgentPartIds::webkitDatetimeEditText):
(WebCore::UserAgentPartIds::webkitDatetimeEditYearField):
(WebCore::UserAgentPartIds::webkitDetailsMarker):
(WebCore::UserAgentPartIds::webkitGenericCueRoot):
(WebCore::UserAgentPartIds::webkitInnerSpinButton):
(WebCore::UserAgentPartIds::webkitListButton):
(WebCore::UserAgentPartIds::webkitMediaTextTrackContainer):
(WebCore::UserAgentPartIds::webkitMediaTextTrackDisplay):
(WebCore::UserAgentPartIds::webkitMediaTextTrackDisplayBackdrop):
(WebCore::UserAgentPartIds::webkitMediaTextTrackRegion):
(WebCore::UserAgentPartIds::webkitMediaTextTrackRegionContainer):
(WebCore::UserAgentPartIds::webkitMeterBar):
(WebCore::UserAgentPartIds::webkitMeterInnerElement):
(WebCore::UserAgentPartIds::webkitMeterOptimumValue):
(WebCore::UserAgentPartIds::webkitMeterSuboptimumValue):
(WebCore::UserAgentPartIds::webkitMeterEvenLessGoodValue):
(WebCore::UserAgentPartIds::webkitProgressBar):
(WebCore::UserAgentPartIds::webkitProgressValue):
(WebCore::UserAgentPartIds::webkitProgressInnerElement):
(WebCore::UserAgentPartIds::webkitSearchDecoration):
(WebCore::UserAgentPartIds::webkitSearchResultsButton):
(WebCore::UserAgentPartIds::webkitSearchResultsDecoration):
(WebCore::UserAgentPartIds::webkitSearchCancelButton):
(WebCore::UserAgentPartIds::webkitSliderRunnableTrack):
(WebCore::UserAgentPartIds::webkitSliderThumb):
(WebCore::UserAgentPartIds::webkitSliderContainer):
(WebCore::UserAgentPartIds::webkitTextfieldDecorationContainer):
(WebCore::UserAgentPartIds::webkitValidationBubble):
(WebCore::UserAgentPartIds::webkitValidationBubbleArrowClipper):
(WebCore::UserAgentPartIds::webkitValidationBubbleArrow):
(WebCore::UserAgentPartIds::webkitValidationBubbleMessage):
(WebCore::UserAgentPartIds::webkitValidationBubbleIcon):
(WebCore::UserAgentPartIds::webkitValidationBubbleTextBlock):
(WebCore::UserAgentPartIds::webkitValidationBubbleHeading):
(WebCore::UserAgentPartIds::webkitValidationBubbleBody):
(WebCore::UserAgentPartIds::appleAttachmentControlsContainer):
* Source/WebCore/html/shadow/UserAgentPartIds.h: Renamed from Source/WebCore/html/shadow/ShadowPseudoIds.h.
* Source/WebCore/html/shadow/YouTubeEmbedShadowElement.cpp:
* Source/WebCore/html/track/TextTrackCue.cpp:
(WebCore::TextTrackCueBox::initialize):
(WebCore::tagPseudoObjects):
(WebCore::TextTrackCue::rebuildDisplayTree):
* Source/WebCore/html/track/VTTCue.cpp:
(WebCore::VTTCue::obtainCSSBoxes):
* Source/WebCore/html/track/VTTRegion.cpp:
(WebCore::VTTRegion::getDisplayTree):
(WebCore::VTTRegion::prepareRegionDisplayTree):
* Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::captionsStyleSheetOverride const):
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::autoAppearanceForElement const):
* Source/WebCore/style/ElementRuleCollector.cpp:
(WebCore::Style::ElementRuleCollector::matchPartPseudoElementRules):
(WebCore::Style::ElementRuleCollector::collectMatchingShadowPseudoElementRules):
* Source/WebCore/style/RuleData.cpp:
(WebCore::Style::determinePropertyAllowlist):
* Source/WebCore/style/StyleAdjuster.cpp:
(WebCore::Style::Adjuster::adjust const):
* Source/WebCore/style/StyleInvalidator.cpp:
(WebCore::Style::Invalidator::invalidateShadowPseudoElements):
* Source/WebCore/style/StyleResolver.cpp:
(WebCore::Style::elementTypeHasAppearanceFromUAStyle):
* Source/WebCore/style/StyleSharingResolver.cpp:
(WebCore::Style::SharingResolver::canShareStyleWithElement const):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::userAgentPartId):
(WebCore::Internals::setUserAgentPartId):
(WebCore::Internals::shadowPseudoId): Deleted.
(WebCore::Internals::setShadowPseudoId): Deleted.
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:

Canonical link: https://commits.webkit.org/272599@main




More information about the webkit-changes mailing list