[webkit-changes] [WebKit/WebKit] 7dcc17: [WebGPU] CTS validation/render_pipeline/overrides....

mwyrzykowski noreply at github.com
Tue Jan 2 23:21:32 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7dcc17c26e0233731a93ff93260d89f251f4440c
      https://github.com/WebKit/WebKit/commit/7dcc17c26e0233731a93ff93260d89f251f4440c
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-01-02 (Tue, 02 Jan 2024)

  Changed paths:
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/render_pipeline/overrides-expected.txt
    M Source/WebCore/Modules/WebGPU/Implementation/WebGPUDeviceImpl.cpp
    M Source/WebGPU/WebGPU/ComputePipeline.mm
    M Source/WebGPU/WebGPU/Pipeline.h
    M Source/WebGPU/WebGPU/Pipeline.mm
    M Source/WebGPU/WebGPU/RenderPipeline.mm
    M Source/WebGPU/WebGPU/ShaderModule.h
    M Source/WebGPU/WebGPU/ShaderModule.mm

  Log Message:
  -----------
  [WebGPU] CTS validation/render_pipeline/overrides.html is failing
https://bugs.webkit.org/show_bug.cgi?id=266736
<radar://119958238>

Reviewed by Tadeu Zagallo.

Add validation for overrides such that render_pipeline/overrides.html now passes.

* LayoutTests/http/tests/webgpu/webgpu/api/validation/render_pipeline/overrides-expected.txt:
Add passing expectations.

* LayoutTests/http/tests/webgpu/webgpu/api/validation/render_pipeline/overrides-expected.txt:
* Source/WebCore/Modules/WebGPU/Implementation/WebGPUDeviceImpl.cpp:
(WebCore::WebGPU::convertToBacking):
* Source/WebGPU/WebGPU/ComputePipeline.mm:
(WebGPU::Device::createComputePipeline):
* Source/WebGPU/WebGPU/Pipeline.h:
* Source/WebGPU/WebGPU/Pipeline.mm:
(WebGPU::createConstantValues):
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::Device::createRenderPipeline):

* Source/WebGPU/WebGPU/ShaderModule.h:
(WebGPU::ShaderModule::create):
* Source/WebGPU/WebGPU/ShaderModule.mm:
(WebGPU::earlyCompileShaderModule):
(WebGPU::handleShaderSuccessOrFailure):
(WebGPU::Device::createShaderModule):
(WebGPU::ShaderModule::ShaderModule):
(WebGPU::ShaderModule::hasOverride const):
Workaround lack of unicode WGSL source support for now until
https://bugs.webkit.org/show_bug.cgi?id=266774 is implemented.

Canonical link: https://commits.webkit.org/272598@main




More information about the webkit-changes mailing list