[webkit-changes] [WebKit/WebKit] 00a7a1: _WKHitTestResult should expose a linkLocalDataMIME...

Jeff Miller noreply at github.com
Wed Jan 3 00:23:51 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 00a7a1e70c1a109781ddb1547e6e58c5e706211e
      https://github.com/WebKit/WebKit/commit/00a7a1e70c1a109781ddb1547e6e58c5e706211e
  Author: Jeff Miller <jeffm at apple.com>
  Date:   2024-01-03 (Wed, 03 Jan 2024)

  Changed paths:
    M Source/WebCore/rendering/HitTestResult.cpp
    M Source/WebCore/rendering/HitTestResult.h
    M Source/WebKit/Shared/API/Cocoa/_WKHitTestResult.h
    M Source/WebKit/Shared/API/Cocoa/_WKHitTestResult.mm
    M Source/WebKit/Shared/WebHitTestResultData.cpp
    M Source/WebKit/Shared/WebHitTestResultData.h
    M Source/WebKit/Shared/WebHitTestResultData.serialization.in
    M Source/WebKit/UIProcess/API/APIHitTestResult.h
    M Tools/TestWebKitAPI/Tests/mac/ContextMenuTests.mm

  Log Message:
  -----------
  _WKHitTestResult should expose a linkLocalDataMIMEType property
https://bugs.webkit.org/show_bug.cgi?id=266730
rdar://119404077

Reviewed by Aditya Keerthi.

Add linkLocalDataMIMEType to WebHitTestResultData (and the underlying plumbing to support calculating
this string) and expose it via a property on _WKHitTestResult.

* Source/WebCore/rendering/HitTestResult.cpp:
(WebCore::HitTestResult::hasLocalDataForLinkURL const):
Added.

* Source/WebCore/rendering/HitTestResult.h:
Added hasLocalDataForLinkURL() and exported it so WebKit can use it.

* Source/WebKit/Shared/API/Cocoa/_WKHitTestResult.h:
Added linkLocalDataMIMEType property.

* Source/WebKit/Shared/API/Cocoa/_WKHitTestResult.mm:
(-[_WKHitTestResult linkLocalDataMIMEType]):
Added.

* Source/WebKit/Shared/WebHitTestResultData.cpp:
(WebKit::webFrameFromHitTestResult):
Refactored from frameInfoDataFromHitTestResult() so we can reuse this logic.

(WebKit::linkLocalDataMIMETypeFromHitTestResult):
Added.

(WebKit::WebHitTestResultData::WebHitTestResultData):
Initialize linkLocalDataMIMEType.

(WebKit::WebHitTestResultData::frameInfoDataFromHitTestResult):
Refactor some logic into webFrameFromHitTestResult().

* Source/WebKit/Shared/WebHitTestResultData.h:
Added linkLocalDataMIMEType.

* Source/WebKit/Shared/WebHitTestResultData.serialization.in:
Added linkLocalDataMIMEType.

* Source/WebKit/UIProcess/API/APIHitTestResult.h:
(API::HitTestResult::linkLocalDataMIMEType const):
Added.

* Tools/TestWebKitAPI/Tests/mac/ContextMenuTests.mm:
(TestWebKitAPI::TEST):
Added HitTestResultLinkLocalDataMIMEType, loads an image inside a link to itself and verifies that the
linkLocalDataMIMEType is "image/jpeg".

Canonical link: https://commits.webkit.org/272600@main




More information about the webkit-changes mailing list