[webkit-changes] [WebKit/WebKit] 76578d: [UnifiedPDF] Selection painting requests should be...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 76578d58608418ccb9ed51f0a5363763a29d4e18
      https://github.com/WebKit/WebKit/commit/76578d58608418ccb9ed51f0a5363763a29d4e18
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2024-02-26 (Mon, 26 Feb 2024)

  Changed paths:
    M Source/WebKit/Platform/spi/Cocoa/PDFKitSPI.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  -----------
  [UnifiedPDF] Selection painting requests should be optimized by specifying dirty rects
https://bugs.webkit.org/show_bug.cgi?id=268927
rdar://122481810

Reviewed by Tim Horton.

Currently, we repaint a lot more than is necessary for selection
changes. This commit optimizes our repaint requests on selection changes
by only asking for the rects corresponding to the bounds of the current
selection (and the old selection) to be repainted.

* Source/WebKit/Platform/spi/Cocoa/PDFKitSPI.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::setNeedsRepaintInDocumentRects):
(WebKit::UnifiedPDFPlugin::windowActivityDidChange):
(WebKit::UnifiedPDFPlugin::selectionBoundsAcrossDocument const):
(WebKit::UnifiedPDFPlugin::repaintOnSelectionActiveStateChangeIfNeeded):
(WebKit::UnifiedPDFPlugin::protectedCurrentSelection const):
(WebKit::UnifiedPDFPlugin::setCurrentSelection):

Canonical link: https://commits.webkit.org/275359@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications