[webkit-changes] [WebKit/WebKit] 94772c: [Test cleanup] Remove redundant tests with "Inline...

Mon Feb 26 18:13:56 PST 2024

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 94772c84562b15144a6b8f579d01dc5377c87331
      https://github.com/WebKit/WebKit/commit/94772c84562b15144a6b8f579d01dc5377c87331
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-02-26 (Mon, 26 Feb 2024)

  Changed paths:
    R LayoutTests/fast/block/float/simple-line-layout-float-shrink-line-expected.html
    R LayoutTests/fast/block/float/simple-line-layout-float-shrink-line.html
    R LayoutTests/fast/block/line-layout/first-line-should-bail-out-of-simple-line-layout-expected.html
    R LayoutTests/fast/block/line-layout/first-line-should-bail-out-of-simple-line-layout.html
    R LayoutTests/fast/css3-text/css3-text-decoration/simple-line-layout-text-decoration-expected.html
    R LayoutTests/fast/css3-text/css3-text-decoration/simple-line-layout-text-decoration.html
    R LayoutTests/fast/css3-text/css3-text-justify/text-justify-last-line-simple-line-layout-expected.html
    R LayoutTests/fast/css3-text/css3-text-justify/text-justify-last-line-simple-line-layout.html
    R LayoutTests/fast/dom/Document/CaretRangeFromPoint/simple-line-layout-hittest-with-caret-range-from-point-expected.html
    R LayoutTests/fast/dom/Document/CaretRangeFromPoint/simple-line-layout-hittest-with-caret-range-from-point.html
    R LayoutTests/fast/dom/Range/simple-line-layout-getclientrects-expected.html
    R LayoutTests/fast/dom/Range/simple-line-layout-getclientrects.html
    R LayoutTests/fast/forms/basic-textareas-quirks-simple-lines-expected.html
    R LayoutTests/fast/forms/basic-textareas-quirks-simple-lines.html
    R LayoutTests/fast/forms/basic-textareas-simple-lines-expected.html
    R LayoutTests/fast/forms/basic-textareas-simple-lines.html
    R LayoutTests/fast/forms/linebox-overflow-in-textarea-padding-simple-lines-expected.html
    R LayoutTests/fast/forms/linebox-overflow-in-textarea-padding-simple-lines.html
    R LayoutTests/fast/forms/negativeLineHeight-simple-lines-expected.html
    R LayoutTests/fast/forms/negativeLineHeight-simple-lines.html
    R LayoutTests/fast/inline/hidpi-legacy-integral-rounding-on-hard-line-break-expected.html
    R LayoutTests/fast/inline/hidpi-legacy-integral-rounding-on-hard-line-break.html
    R LayoutTests/fast/inline/hidpi-legacy-integral-rounding-on-inline-boxes-expected.html
    R LayoutTests/fast/inline/hidpi-legacy-integral-rounding-on-inline-boxes.html
    R LayoutTests/fast/inline/simple-line-layout-16bit-content-expected.html
    R LayoutTests/fast/inline/simple-line-layout-16bit-content.html
    R LayoutTests/fast/multicol/orphans-ignored-expected.html
    R LayoutTests/fast/multicol/orphans-ignored.html
    R LayoutTests/fast/text/line-runs-rounding-simple-lines-expected.html
    R LayoutTests/fast/text/line-runs-rounding-simple-lines.html
    R LayoutTests/fast/text/mark-matches-rendering-simple-lines-expected.html
    R LayoutTests/fast/text/mark-matches-rendering-simple-lines.html
    R LayoutTests/fast/text/multiple-renderers-with-hypen-on-boundary-expected.html
    R LayoutTests/fast/text/multiple-renderers-with-hypen-on-boundary.html
    R LayoutTests/fast/text/negative-letter-spacing-visual-overflow-expected.html
    R LayoutTests/fast/text/negative-letter-spacing-visual-overflow.html
    R LayoutTests/fast/text/simple-line-layout-dynamic-letter-word-spacing-expected.html
    R LayoutTests/fast/text/simple-line-layout-dynamic-letter-word-spacing.html
    R LayoutTests/fast/text/simple-line-layout-fallback-space-glyph-expected.html
    R LayoutTests/fast/text/simple-line-layout-fallback-space-glyph.html
    R LayoutTests/fast/text/simple-line-layout-glyph-overflows-line-expected.html
    R LayoutTests/fast/text/simple-line-layout-glyph-overflows-line.html
    R LayoutTests/fast/text/simple-line-layout-hyphen-limit-lines2-expected.html
    R LayoutTests/fast/text/simple-line-layout-hyphen-limit-lines2.html
    R LayoutTests/fast/text/simple-line-layout-hyphenation-limit-lines-accross-words-expected.html
    R LayoutTests/fast/text/simple-line-layout-hyphenation-limit-lines-accross-words.html
    R LayoutTests/fast/text/simple-line-layout-multiple-renderers-non-breaking-space-expected.html
    R LayoutTests/fast/text/simple-line-layout-multiple-renderers-non-breaking-space.html
    R LayoutTests/fast/text/simple-line-layout-multiple-renderers-with-float-expected.html
    R LayoutTests/fast/text/simple-line-layout-multiple-renderers-with-float.html
    R LayoutTests/fast/text/simple-line-layout-selection-with-overflow-expected.html
    R LayoutTests/fast/text/simple-line-layout-selection-with-overflow.html
    R LayoutTests/fast/text/simple-line-layout-text-position-with-stroke-expected.html
    R LayoutTests/fast/text/simple-line-layout-text-position-with-stroke.html
    R LayoutTests/fast/text/simple-line-layout-with-justified-punctuation-expected.html
    R LayoutTests/fast/text/simple-line-layout-with-justified-punctuation.html
    R LayoutTests/fast/text/simple-line-layout-wrapping-multiple-renderers-hang-expected.html
    R LayoutTests/fast/text/simple-line-layout-wrapping-multiple-renderers-hang.html
    R LayoutTests/fast/text/simple-line-letterspacing-expected.html
    R LayoutTests/fast/text/simple-line-letterspacing.html
    R LayoutTests/fast/text/simple-line-text-indent-expected.html
    R LayoutTests/fast/text/simple-line-text-indent.html
    R LayoutTests/fast/text/simple-line-text-measuring-with-trailing-space-expected.html
    R LayoutTests/fast/text/simple-line-text-measuring-with-trailing-space.html
    R LayoutTests/fast/text/simple-line-with-br-expected.html
    R LayoutTests/fast/text/simple-line-with-br.html
    R LayoutTests/fast/text/simple-line-with-multiple-renderers-expected.html
    R LayoutTests/fast/text/simple-line-with-multiple-renderers.html
    R LayoutTests/fast/text/simple-line-wordspacing-expected.html
    R LayoutTests/fast/text/simple-line-wordspacing.html
    R LayoutTests/fast/text/simple-lines-float-compare-expected.html
    R LayoutTests/fast/text/simple-lines-float-compare.html
    R LayoutTests/fast/text/simple-lines-intruding-wide-float-expected.html
    R LayoutTests/fast/text/simple-lines-intruding-wide-float.html
    R LayoutTests/fast/text/simple-lines-range-low-line-height-expected.html
    R LayoutTests/fast/text/simple-lines-range-low-line-height.html
    R LayoutTests/fast/text/simple-lines-text-transform-expected.html
    R LayoutTests/fast/text/simple-lines-text-transform.html
    R LayoutTests/fast/text/whitespace/pre-wrap-line-test-simple-lines-expected.html
    R LayoutTests/fast/text/whitespace/pre-wrap-line-test-simple-lines.html
    R LayoutTests/fast/text/whitespace/pre-wrap-spaces-after-newline-simple-lines-expected.html
    R LayoutTests/fast/text/whitespace/pre-wrap-spaces-after-newline-simple-lines.html
    R LayoutTests/fast/text/whitespace/simple-line-layout-tab-position-expected.html
    R LayoutTests/fast/text/whitespace/simple-line-layout-tab-position.html
    M LayoutTests/platform/glib/TestExpectations
    M LayoutTests/platform/gtk/TestExpectations
    M LayoutTests/platform/ios/TestExpectations
    M LayoutTests/platform/wincairo/TestExpectations
    M LayoutTests/platform/wpe/TestExpectations
    R LayoutTests/printing/simple-lines-break-expected.html
    R LayoutTests/printing/simple-lines-break.html

  Log Message:
  -----------
  [Test cleanup] Remove redundant tests with "InlineFormattingContextIntegrationEnabled=false" (part II)
https://bugs.webkit.org/show_bug.cgi?id=270107

Reviewed by Antti Koivisto.

These tests fall under the following categories:
- testing dynamic switching between IFC and legacy line layout
- testing that certain content is laid out specifically using IFC/legacy line layout
- testing geometry matching between the 2 codepaths

(test content extracted from existing test cases/functionality already covered by adjacent tests)

* LayoutTests/fast/block/float/simple-line-layout-float-shrink-line-expected.html: Removed.
* LayoutTests/fast/block/float/simple-line-layout-float-shrink-line.html: Removed.
* LayoutTests/fast/block/line-layout/first-line-should-bail-out-of-simple-line-layout-expected.html: Removed.
* LayoutTests/fast/block/line-layout/first-line-should-bail-out-of-simple-line-layout.html: Removed.
* LayoutTests/fast/css3-text/css3-text-decoration/simple-line-layout-text-decoration-expected.html: Removed.
* LayoutTests/fast/css3-text/css3-text-decoration/simple-line-layout-text-decoration.html: Removed.
* LayoutTests/fast/css3-text/css3-text-justify/text-justify-last-line-simple-line-layout-expected.html: Removed.
* LayoutTests/fast/css3-text/css3-text-justify/text-justify-last-line-simple-line-layout.html: Removed.
* LayoutTests/fast/dom/Document/CaretRangeFromPoint/simple-line-layout-hittest-with-caret-range-from-point-expected.html: Removed.
* LayoutTests/fast/dom/Document/CaretRangeFromPoint/simple-line-layout-hittest-with-caret-range-from-point.html: Removed.
* LayoutTests/fast/dom/Range/simple-line-layout-getclientrects-expected.html: Removed.
* LayoutTests/fast/dom/Range/simple-line-layout-getclientrects.html: Removed.
* LayoutTests/fast/forms/basic-textareas-quirks-simple-lines-expected.html: Removed.
* LayoutTests/fast/forms/basic-textareas-quirks-simple-lines.html: Removed.
* LayoutTests/fast/forms/basic-textareas-simple-lines-expected.html: Removed.
* LayoutTests/fast/forms/basic-textareas-simple-lines.html: Removed.
* LayoutTests/fast/forms/linebox-overflow-in-textarea-padding-simple-lines-expected.html: Removed.
* LayoutTests/fast/forms/linebox-overflow-in-textarea-padding-simple-lines.html: Removed.
* LayoutTests/fast/forms/negativeLineHeight-simple-lines-expected.html: Removed.
* LayoutTests/fast/forms/negativeLineHeight-simple-lines.html: Removed.
* LayoutTests/fast/inline/hidpi-legacy-integral-rounding-on-hard-line-break-expected.html: Removed.
* LayoutTests/fast/inline/hidpi-legacy-integral-rounding-on-hard-line-break.html: Removed.
* LayoutTests/fast/inline/hidpi-legacy-integral-rounding-on-inline-boxes-expected.html: Removed.
* LayoutTests/fast/inline/hidpi-legacy-integral-rounding-on-inline-boxes.html: Removed.
* LayoutTests/fast/inline/simple-line-layout-16bit-content-expected.html: Removed.
* LayoutTests/fast/inline/simple-line-layout-16bit-content.html: Removed.
* LayoutTests/fast/multicol/orphans-ignored-expected.html: Removed.
* LayoutTests/fast/multicol/orphans-ignored.html: Removed.
* LayoutTests/fast/text/line-runs-rounding-simple-lines-expected.html: Removed.
* LayoutTests/fast/text/line-runs-rounding-simple-lines.html: Removed.
* LayoutTests/fast/text/mark-matches-rendering-simple-lines-expected.html: Removed.
* LayoutTests/fast/text/mark-matches-rendering-simple-lines.html: Removed.
* LayoutTests/fast/text/multiple-renderers-with-hypen-on-boundary-expected.html: Removed.
* LayoutTests/fast/text/multiple-renderers-with-hypen-on-boundary.html: Removed.
* LayoutTests/fast/text/negative-letter-spacing-visual-overflow-expected.html: Removed.
* LayoutTests/fast/text/negative-letter-spacing-visual-overflow.html: Removed.
* LayoutTests/fast/text/simple-line-layout-dynamic-letter-word-spacing-expected.html: Removed.
* LayoutTests/fast/text/simple-line-layout-dynamic-letter-word-spacing.html: Removed.
* LayoutTests/fast/text/simple-line-layout-fallback-space-glyph-expected.html: Removed.
* LayoutTests/fast/text/simple-line-layout-fallback-space-glyph.html: Removed.
* LayoutTests/fast/text/simple-line-layout-glyph-overflows-line-expected.html: Removed.
* LayoutTests/fast/text/simple-line-layout-glyph-overflows-line.html: Removed.
* LayoutTests/fast/text/simple-line-layout-hyphen-limit-lines2-expected.html: Removed.
* LayoutTests/fast/text/simple-line-layout-hyphen-limit-lines2.html: Removed.
* LayoutTests/fast/text/simple-line-layout-hyphenation-limit-lines-accross-words-expected.html: Removed.
* LayoutTests/fast/text/simple-line-layout-hyphenation-limit-lines-accross-words.html: Removed.
* LayoutTests/fast/text/simple-line-layout-multiple-renderers-non-breaking-space-expected.html: Removed.
* LayoutTests/fast/text/simple-line-layout-multiple-renderers-non-breaking-space.html: Removed.
* LayoutTests/fast/text/simple-line-layout-multiple-renderers-with-float-expected.html: Removed.
* LayoutTests/fast/text/simple-line-layout-multiple-renderers-with-float.html: Removed.
* LayoutTests/fast/text/simple-line-layout-selection-with-overflow-expected.html: Removed.
* LayoutTests/fast/text/simple-line-layout-selection-with-overflow.html: Removed.
* LayoutTests/fast/text/simple-line-layout-text-position-with-stroke-expected.html: Removed.
* LayoutTests/fast/text/simple-line-layout-text-position-with-stroke.html: Removed.
* LayoutTests/fast/text/simple-line-layout-with-justified-punctuation-expected.html: Removed.
* LayoutTests/fast/text/simple-line-layout-with-justified-punctuation.html: Removed.
* LayoutTests/fast/text/simple-line-layout-wrapping-multiple-renderers-hang-expected.html: Removed.
* LayoutTests/fast/text/simple-line-layout-wrapping-multiple-renderers-hang.html: Removed.
* LayoutTests/fast/text/simple-line-letterspacing-expected.html: Removed.
* LayoutTests/fast/text/simple-line-letterspacing.html: Removed.
* LayoutTests/fast/text/simple-line-text-indent-expected.html: Removed.
* LayoutTests/fast/text/simple-line-text-indent.html: Removed.
* LayoutTests/fast/text/simple-line-text-measuring-with-trailing-space-expected.html: Removed.
* LayoutTests/fast/text/simple-line-text-measuring-with-trailing-space.html: Removed.
* LayoutTests/fast/text/simple-line-with-br-expected.html: Removed.
* LayoutTests/fast/text/simple-line-with-br.html: Removed.
* LayoutTests/fast/text/simple-line-with-multiple-renderers-expected.html: Removed.
* LayoutTests/fast/text/simple-line-with-multiple-renderers.html: Removed.
* LayoutTests/fast/text/simple-line-wordspacing-expected.html: Removed.
* LayoutTests/fast/text/simple-line-wordspacing.html: Removed.
* LayoutTests/fast/text/simple-lines-float-compare-expected.html: Removed.
* LayoutTests/fast/text/simple-lines-float-compare.html: Removed.
* LayoutTests/fast/text/simple-lines-intruding-wide-float-expected.html: Removed.
* LayoutTests/fast/text/simple-lines-intruding-wide-float.html: Removed.
* LayoutTests/fast/text/simple-lines-range-low-line-height-expected.html: Removed.
* LayoutTests/fast/text/simple-lines-range-low-line-height.html: Removed.
* LayoutTests/fast/text/simple-lines-text-transform-expected.html: Removed.
* LayoutTests/fast/text/simple-lines-text-transform.html: Removed.
* LayoutTests/fast/text/whitespace/pre-wrap-line-test-simple-lines-expected.html: Removed.
* LayoutTests/fast/text/whitespace/pre-wrap-line-test-simple-lines.html: Removed.
* LayoutTests/fast/text/whitespace/pre-wrap-spaces-after-newline-simple-lines-expected.html: Removed.
* LayoutTests/fast/text/whitespace/pre-wrap-spaces-after-newline-simple-lines.html: Removed.
* LayoutTests/fast/text/whitespace/simple-line-layout-tab-position-expected.html: Removed.
* LayoutTests/fast/text/whitespace/simple-line-layout-tab-position.html: Removed.
* LayoutTests/printing/simple-lines-break-expected.html: Removed.
* LayoutTests/printing/simple-lines-break.html: Removed.

Canonical link: https://commits.webkit.org/275358@main

To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications