[webkit-changes] [WebKit/WebKit] eeef2a: Close extension popup web views when the web conte...

Brian Weinstein noreply at github.com
Mon Feb 26 18:37:21 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: eeef2a286027af94c7d9117260bbb72142545569
      https://github.com/WebKit/WebKit/commit/eeef2a286027af94c7d9117260bbb72142545569
  Author: Brian Weinstein <bweinstein at apple.com>
  Date:   2024-02-26 (Mon, 26 Feb 2024)

  Changed paths:
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm

  Log Message:
  -----------
  Close extension popup web views when the web content process terminates or window.close is called
https://bugs.webkit.org/show_bug.cgi?id=270130
rdar://123468009

Reviewed by Timothy Hatcher.

On iOS, this will lead to the UIViewController being closed, which leads to a better experience for the client.

On Mac, if the web view lives in an NSPanel, WebKit will close the window that the web view is in.

* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm:
(-[_WKWebExtensionActionWebViewDelegate webViewWebContentProcessDidTerminate:]):
(-[_WKWebExtensionActionWebViewDelegate webViewDidClose:]):

Canonical link: https://commits.webkit.org/275360@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list