[webkit-changes] [WebKit/WebKit] 609d2a: Use smart pointers when accessing ScrollingCoordin...

[Rob Buis]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 609d2a48b1c0c4ea074073c1f0e30a25efae25a2
      https://github.com/WebKit/WebKit/commit/609d2a48b1c0c4ea074073c1f0e30a25efae25a2
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2024-08-24 (Sat, 24 Aug 2024)

  Changed paths:
    M Source/WebCore/page/Frame.cpp
    M Source/WebCore/page/LocalFrameView.cpp
    M Source/WebCore/page/mac/EventHandlerMac.mm
    M Source/WebCore/rendering/RenderLayer.cpp
    M Source/WebCore/rendering/RenderLayerBacking.cpp
    M Source/WebCore/rendering/RenderLayerCompositor.cpp
    M Source/WebCore/rendering/RenderLayerScrollableArea.cpp
    M Source/WebCore/testing/Internals.cpp

  Log Message:
  -----------
  Use smart pointers when accessing ScrollingCoordinator
https://bugs.webkit.org/show_bug.cgi?id=278561

Reviewed by Chris Dumez.

Use smart pointers when accessing ScrollingCoordinator
based on [alpha.webkit.UncountedCallArgsChecker] warnings.

* Source/WebCore/page/Frame.cpp:
(WebCore::Frame::detachFromPage):
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::prepareForDetach):
(WebCore::LocalFrameView::isScrollSnapInProgress const):
(WebCore::LocalFrameView::usesAsyncScrolling const):
(WebCore::LocalFrameView::addViewportConstrainedObject):
(WebCore::LocalFrameView::removeViewportConstrainedObject):
(WebCore::LocalFrameView::shouldUpdateCompositingLayersAfterScrolling const):
(WebCore::LocalFrameView::isUserScrollInProgress const):
(WebCore::LocalFrameView::isRubberBandInProgress const):
(WebCore::LocalFrameView::requestStartKeyboardScrollAnimation):
(WebCore::LocalFrameView::requestStopKeyboardScrollAnimation):
(WebCore::LocalFrameView::requestScrollToPosition):
(WebCore::LocalFrameView::stopAsyncAnimatedScroll):
(WebCore::LocalFrameView::layoutOrVisualViewportChanged):
(WebCore::LocalFrameView::performPostLayoutTasks):
(WebCore::LocalFrameView::scrollableAreaSetChanged):
(WebCore::LocalFrameView::handleWheelEventForScrolling):
(WebCore::LocalFrameView::setScrollPinningBehavior):
* Source/WebCore/page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::wheelEventWasProcessedByMainThread):
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setupFontSubpixelQuantization):
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateOverflowControlsLayers):
(WebCore::RenderLayerBacking::detachFromScrollingCoordinator):
* Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::didChangePlatformLayerForLayer):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::updateBacking):
(WebCore::RenderLayerCompositor::hasCoordinatedScrolling const):
(WebCore::RenderLayerCompositor::attachWidgetContentLayersIfNecessary):
(WebCore::RenderLayerCompositor::useCoordinatedScrollingForLayer const):
(WebCore::RenderLayerCompositor::isLayerForIFrameWithScrollCoordinatedContents const):
(WebCore::RenderLayerCompositor::updateLayerForHeader):
(WebCore::RenderLayerCompositor::updateLayerForFooter):
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
(WebCore::RenderLayerCompositor::destroyRootLayer):
(WebCore::RenderLayerCompositor::detachRootLayer):
(WebCore::RenderLayerCompositor::updateScrollingNodeForViewportConstrainedRole):
(WebCore::RenderLayerCompositor::updateScrollingNodeForScrollingRole):
(WebCore::RenderLayerCompositor::updateScrollingNodeForScrollingProxyRole):
(WebCore::RenderLayerCompositor::updateScrollingNodeForFrameHostingRole):
(WebCore::RenderLayerCompositor::updateScrollingNodeForPositioningRole):
(WebCore::RenderLayerCompositor::updateSynchronousScrollingNodes):
(WebCore::RenderLayerCompositor::updateScrollSnapPropertiesWithFrameView const):
* Source/WebCore/rendering/RenderLayerScrollableArea.cpp:
(WebCore::RenderLayerScrollableArea::clear):
(WebCore::RenderLayerScrollableArea::isUserScrollInProgress const):
(WebCore::RenderLayerScrollableArea::isRubberBandInProgress const):
(WebCore::RenderLayerScrollableArea::requestScrollToPosition):
(WebCore::RenderLayerScrollableArea::requestStartKeyboardScrollAnimation):
(WebCore::RenderLayerScrollableArea::requestStopKeyboardScrollAnimation):
(WebCore::RenderLayerScrollableArea::stopAsyncAnimatedScroll):
(WebCore::RenderLayerScrollableArea::handleWheelEventForScrolling):
(WebCore::RenderLayerScrollableArea::isScrollSnapInProgress const):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::scrollBySimulatingWheelEvent):
(WebCore::Internals::scrollingTreeAsText const):
(WebCore::Internals::haveScrollingTree const):

Canonical link: https://commits.webkit.org/282697@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications