[webkit-changes] [WebKit/WebKit] f22919: Align `SVGGeometryElement::getPointAtLength` order...

Ahmad Saleem noreply at github.com
Sat Aug 24 00:15:24 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f2291919b0155956f5d40fb0227f72ddfaaeb577
      https://github.com/WebKit/WebKit/commit/f2291919b0155956f5d40fb0227f72ddfaaeb577
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2024-08-24 (Sat, 24 Aug 2024)

  Changed paths:
    M Source/WebCore/svg/SVGGeometryElement.cpp

  Log Message:
  -----------
  Align `SVGGeometryElement::getPointAtLength` order as per web specification order
https://bugs.webkit.org/show_bug.cgi?id=278591
rdar://134596316

Reviewed by Anne van Kesteren.

In PR#32623 (282665 at main), Anne shared feedback on ordering of implementation and
later noticed that the same is applicable for `SVGGeometryElement::getPointAtLength`.

This patch is to move `non-rendered element` case before clamping as it is
in web specification [1]:

[1] https://svgwg.org/svg2-draft/types.html#InterfaceSVGGeometryElement

It has following order:

1. If current element is a non-rendered element,...
2. ...
3. Clamp distance to [0, length].

* Source/WebCore/svg/SVGGeometryElement.cpp:
(WebCore::SVGGeometryElement::getPointAtLength const):

Canonical link: https://commits.webkit.org/282698@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list