[webkit-changes] [WebKit/WebKit] 21b25e: Replace some callers of RenderStyle::getRoundedInn...

Simon Fraser noreply at github.com
Fri Aug 23 23:27:47 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 21b25ead929ea018acc9522cd3543798e12ba281
      https://github.com/WebKit/WebKit/commit/21b25ead929ea018acc9522cd3543798e12ba281
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2024-08-23 (Fri, 23 Aug 2024)

  Changed paths:
    M Source/WebCore/rendering/BorderShape.cpp
    M Source/WebCore/rendering/BorderShape.h
    M Source/WebCore/rendering/RenderLayer.cpp
    M Source/WebCore/rendering/RenderLayerBacking.cpp
    M Source/WebCore/rendering/RenderLayerCompositor.cpp

  Log Message:
  -----------
  Replace some callers of RenderStyle::getRoundedInnerBorderFor() with BorderShape
https://bugs.webkit.org/show_bug.cgi?id=278582
rdar://134590752

Reviewed by Alan Baradlay.

Callers of `RenderStyle::getRoundedInnerBorderFor()` can now create a `BorderShape`
and use one of its functions to get the inner rounded rect. Convert code in
RenderLayer, RenderLayerBacking and RenderLayerCompositor accordingly.

Add a function to BorderShape that asks "is the given rectangle entirely
inside the inner shape", which will eventually need to handle not just rounded
corners.

* Source/WebCore/rendering/BorderShape.cpp:
(WebCore::BorderShape::innerShapeContains const):
* Source/WebCore/rendering/BorderShape.h:
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::clipToRect):
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGeometry):
* Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeAncestorClippingStack const):
(WebCore::RenderLayerCompositor::parentRelativeScrollableRect const):

Canonical link: https://commits.webkit.org/282696@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list