[webkit-changes] [WebKit/WebKit] 18c176: check-webkit-style assertion failure in Source/Web...

Commit Queue noreply at github.com
Sat Sep 9 11:24:40 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 18c176998114e1ca89b5c213a21f74dd57b9c316
      https://github.com/WebKit/WebKit/commit/18c176998114e1ca89b5c213a21f74dd57b9c316
  Author: David Kilzer <ddkilzer at apple.com>
  Date:   2023-09-09 (Sat, 09 Sep 2023)

  Changed paths:
    M Tools/Scripts/webkitpy/style/checkers/cpp.py
    M Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py

  Log Message:
  -----------
  check-webkit-style assertion failure in Source/WebCore/PAL/ThirdParty/libavif/ThirdParty/dav1d/src/thread_task.c
https://bugs.webkit.org/show_bug.cgi?id=261309
<rdar://115150139>

Reviewed by Jonathan Bedard.

* Tools/Scripts/webkitpy/style/checkers/cpp.py:
(check_identifier_name_in_declaration):
- Don't attempt to check variable names in 'case' statements since this
  code was not designed to do that. A stray semi-colon after a
  'case XYZ:;' statement caused 'XYZ:' to be treated as a variable.

* Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest):
- Add a unit test.

Canonical link: https://commits.webkit.org/267833@main




More information about the webkit-changes mailing list