[webkit-changes] [WebKit/WebKit] a8d8da: Add clear buttons to All Paths To... section of GC...

[Ryan Reno]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a8d8da847b5febadb0e97875028dee1302ed6331
      https://github.com/WebKit/WebKit/commit/a8d8da847b5febadb0e97875028dee1302ed6331
  Author: Ryan Reno <rreno at apple.com>
  Date:   2023-09-09 (Sat, 09 Sep 2023)

  Changed paths:
    M Tools/GCHeapInspector/script/interface.js

  Log Message:
  -----------
  Add clear buttons to All Paths To... section of GCHeapInspector UI
https://bugs.webkit.org/show_bug.cgi?id=261375
rdar://115223418

Reviewed by Simon Fraser.

This adds both a "Clear All" button to the All Paths To... section as
well as individual "Clear" buttons for each object added to this section
of the UI.

In some cases, depending on the heap, we could end up with objects which
have tens of thousands of paths to them in the heap. When this object
is added to the All Paths section we could create well over 16GB of DOM
and Text nodes for all of these paths causing the web process to be
killed in the foreground if these nodes can't be garbage collected.

These buttons will allow a user to remove sections from the All Paths
section when they're no longer of interest, giving the GC a chance to
collect all these excess nodes and help improve memory performance for
this tool.

* Tools/GCHeapInspector/script/interface.js:
(HeapSnapshotInspector.prototype.resetUI):
(HeapSnapshotInspector.prototype.addClearButtonToDetailsNode):
(HeapSnapshotInspector.prototype.showAllPathsToNode):
(HeapSnapshotInspector):

Canonical link: https://commits.webkit.org/267834@main