[webkit-changes] [WebKit/WebKit] e01908: [IFC] Merge InlineContentBuilder::computeIsFirstIs...

Alan Baradlay noreply at github.com
Sat Sep 9 10:28:48 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e01908325278b4e55f998f1f36473ea897863cae
      https://github.com/WebKit/WebKit/commit/e01908325278b4e55f998f1f36473ea897863cae
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-09-09 (Sat, 09 Sep 2023)

  Changed paths:
    M Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentBuilder.cpp
    M Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentBuilder.h

  Log Message:
  -----------
  [IFC] Merge InlineContentBuilder::computeIsFirstIsLastBoxForInlineContent and updateIfTextRenderersNeedVisualReordering
https://bugs.webkit.org/show_bug.cgi?id=261352

Reviewed by Antti Koivisto.

Let's not iterate through the same set of boxes twice.

* Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentBuilder.cpp:
(WebCore::LayoutIntegration::InlineContentBuilder::build const):
(WebCore::LayoutIntegration::InlineContentBuilder::computeIsFirstIsLastBoxAndBidiReorderingForInlineContent const):
(WebCore::LayoutIntegration::InlineContentBuilder::computeIsFirstIsLastBoxForInlineContent const): Deleted.
(WebCore::LayoutIntegration::InlineContentBuilder::updateIfTextRenderersNeedVisualReordering const): Deleted.
* Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentBuilder.h:

Canonical link: https://commits.webkit.org/267832@main




More information about the webkit-changes mailing list