[webkit-changes] [WebKit/WebKit] 068189: REGRESSION(267683 at main): [ iOS ] platform/ios/medi...

youennf noreply at github.com
Fri Oct 27 10:02:03 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 068189b33d98adaaa8476b2d999e60e4e90bacfb
      https://github.com/WebKit/WebKit/commit/068189b33d98adaaa8476b2d999e60e4e90bacfb
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2023-10-27 (Fri, 27 Oct 2023)

  Changed paths:
    M LayoutTests/platform/ios/TestExpectations
    M LayoutTests/platform/ios/mediastream/getUserMedia-override-audio-session-interruption.html
    M Source/WebCore/platform/audio/AudioSession.h
    M Source/WebCore/testing/Internals.cpp
    M Source/WebCore/testing/Internals.h
    M Source/WebCore/testing/Internals.idl
    M Source/WebKit/WebProcess/GPU/media/RemoteAudioSession.h

  Log Message:
  -----------
  REGRESSION(267683 at main): [ iOS ] platform/ios/mediastream/getUserMedia-override-audio-session-interruption.html is a consistent text failure
https://bugs.webkit.org/show_bug.cgi?id=263479
rdar://problem/117282117

Reviewed by Eric Carlson.

In 267683 at main, we added support for failing tryToSetActivate in case of interruption like happens in a phone call.
This broke this test which expects to end interruption in case of calling getUserMedia and phone call is ended (but we did not receive the end interruption).
To be able to test this case, we are introducing a new internals API that clears the interruption flag, which will allow tryToSetActivate to succeed.

* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/ios/mediastream/getUserMedia-override-audio-session-interruption.html:
* Source/WebCore/platform/audio/AudioSession.h:
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::clearAudioSessionInterruptionFlag):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:
* Source/WebKit/WebProcess/GPU/media/RemoteAudioSession.h:

Canonical link: https://commits.webkit.org/269855@main




More information about the webkit-changes mailing list