[webkit-changes] [WebKit/WebKit] 8ce6e6: [macOS MiniBrowser] Implement pointer lock client ...
Abrar Rahman Protyasha
noreply at github.com
Fri Oct 27 09:52:33 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8ce6e671f9d0f1e22d3125f12884efb9996e93bd
https://github.com/WebKit/WebKit/commit/8ce6e671f9d0f1e22d3125f12884efb9996e93bd
Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
Date: 2023-10-27 (Fri, 27 Oct 2023)
Changed paths:
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Tools/MiniBrowser/mac/WK2BrowserWindowController.m
Log Message:
-----------
[macOS MiniBrowser] Implement pointer lock client delegates and display banner
https://bugs.webkit.org/show_bug.cgi?id=263757
rdar://117562146
Reviewed by Aditya Keerthi.
Right now, you can't enter pointer lock in MiniBrowser because it does
not provide an implementation for the `_webViewDidRequestPointerLock`
client delegate method.
We should address this by providing implementations for both
`_webViewDidRequestPointerLock` and `_webViewDidLosePointerLock`,
allowing us to display a banner that informs the user about their
pointer (and instructs how to exit out of the pointer lock state).
* Source/WebKit/UIProcess/WebPageProxy.cpp:
Drive-by fix to include what condition the `#endif` clause is
terminating.
* Tools/MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]):
Initialize the `_pointerLockBanner` layer here.
(-[WK2BrowserWindowController _webViewDidRequestPointerLock:completionHandler:]):
(-[WK2BrowserWindowController _webViewDidLosePointerLock:]):
Canonical link: https://commits.webkit.org/269854@main
More information about the webkit-changes
mailing list