[webkit-changes] [WebKit/WebKit] a8ac4a: REGRESSION (269779 at main): [ macOS iOS 17 ] 3 API t...

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a8ac4a4cdd3f698758df2e2d4a053fa0676ac9f5
      https://github.com/WebKit/WebKit/commit/a8ac4a4cdd3f698758df2e2d4a053fa0676ac9f5
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-10-27 (Fri, 27 Oct 2023)

  Changed paths:
    M Source/WebGPU/WGSL/Lexer.cpp
    M Tools/TestWebKitAPI/Tests/WGSL/LexerTests.cpp

  Log Message:
  -----------
  REGRESSION (269779 at main): [ macOS iOS 17 ] 3 API tests in TestWGSL is a consistent failure/crash
https://bugs.webkit.org/show_bug.cgi?id=263746
rdar://117553256

Reviewed by Mike Wyrzykowski.

We had 4 test cases failing, which consisted of 3 incorrect tests and 1 edge case:
- The edge case was when we parse a floating point at the end of the input source,
  ending with a period (the test was `01.`). We have to run the state machine once
  more past the end of the file to read the EOF char and either return an error or
  terminate a valid number token.
- 2 tests were parsing numbers that had the `f` suffix in the WGSL source, but
  comparing against a double value in C++. Originally the lexer did not perform
  the narrowing to float, so the comparison passed, but it shouldn't, so I updated
  the expectations.
- The last failing test was an invalid input (`42e-4`), which now correctly
  returns an invalid token.

* Source/WebGPU/WGSL/Lexer.cpp:
(WGSL::Lexer<T>::lexNumber):
* Tools/TestWebKitAPI/Tests/WGSL/LexerTests.cpp:
(TestWGSLAPI::TEST):

Canonical link: https://commits.webkit.org/269856@main