[webkit-changes] [WebKit/WebKit] 42d74b: [UnifiedPDF] Move back to PDFKit/PDFPage rendering...

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 42d74b74eedd1cc519a729cc86b5568b4e5be315
      https://github.com/WebKit/WebKit/commit/42d74b74eedd1cc519a729cc86b5568b4e5be315
  Author: Tim Horton <timothy_horton at apple.com>
  Date:   2023-11-10 (Fri, 10 Nov 2023)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.mm
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  -----------
  [UnifiedPDF] Move back to PDFKit/PDFPage rendering (instead of CGPDF)
https://bugs.webkit.org/show_bug.cgi?id=264614
<rdar://problem/118155116>

Reviewed by Simon Fraser.

We're likely to need lots of PDFKit conveniences, and it's available
cross-platform, so we should just use PDFKit.

* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::isLocked const): Deleted.
(WebKit::PDFPlugin::createPDFDocument): Deleted.
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm:
(WebKit::PDFPluginBase::createPDFDocument):
(WebKit::PDFPluginBase::isLocked const):
(WebKit::PDFPluginBase::rawData const):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::installPDFDocument):
(WebKit::UnifiedPDFPlugin::createPDFDocument): Deleted.
(WebKit::UnifiedPDFPlugin::isLocked const): Deleted.
Hoist PDFDocument creation, isLocked(), rawData(), and m_pdfDocument.

(WebKit::UnifiedPDFPlugin::paintContents):
Use PDFPage painting.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.h:
(WebKit::PDFDocumentLayout::setPDFDocument):
(WebKit::PDFDocumentLayout::pdfDocument const): Deleted.
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.mm:
(WebKit::PDFDocumentLayout::pageAtIndex const):
(WebKit::PDFDocumentLayout::updateLayout):
(WebKit::PDFDocumentLayout::pageCount const):
(WebKit::PDFDocumentLayout::setPDFDocument): Deleted.
(WebKit::PDFDocumentLayout::hasPDFDocument const): Deleted.
Use PDFDocument and PDFPage for retrieving pages and page layout information.

Canonical link: https://commits.webkit.org/270572@main